Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2452893002: sync compositor: Signal futures on channel shutdown (Closed)

Created:
4 years, 1 month ago by boliu
Modified:
4 years, 1 month ago
Reviewers:
sgurun-gerrit only
CC:
chromium-reviews, jam, darin-cc_chromium.org, Tobias Sargeant
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

sync compositor: Signal futures on channel shutdown If the channel shutdown (cleanly or on error) while there are still pending frame futures in the filter, then browser may wait indefinitely on those futures. In this case, signal those futures with empty frames. What frame gets drawn in these cases do not matter very much. Also add a |filter_ready_| state so that new futures inserted gets signaled immediately. BUG=636164 Committed: https://crrev.com/3e3ad9a95aa746107d49fd120811e686b915e861 Cr-Commit-Position: refs/heads/master@{#427742}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -5 lines) Patch
M content/browser/android/synchronous_compositor_browser_filter.h View 2 chunks +7 lines, -2 lines 0 comments Download
M content/browser/android/synchronous_compositor_browser_filter.cc View 3 chunks +31 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
boliu
ptal
4 years, 1 month ago (2016-10-26 15:46:40 UTC) #2
sgurun-gerrit only
lgtm
4 years, 1 month ago (2016-10-26 17:23:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2452893002/1
4 years, 1 month ago (2016-10-26 17:26:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 18:07:22 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 18:21:49 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e3ad9a95aa746107d49fd120811e686b915e861
Cr-Commit-Position: refs/heads/master@{#427742}

Powered by Google App Engine
This is Rietveld 408576698