Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 2452873002: Revert of Upgrade to new Android SDK. (Closed)

Created:
4 years, 1 month ago by ynovikov
Modified:
4 years, 1 month ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org, pauljensen
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Upgrade to new Android SDK. (patchset #1 id:1 of https://codereview.chromium.org/2442363003/ ) Reason for revert: Breaks Android GPU.FYI bots. Original issue's description: > Reland of Upgrade to new Android SDK. (patchset #1 id:1 of https://codereview.chromium.org/2438913004/ ) > > Reason for revert: > With https://codereview.chromium.org/2447583002/ and https://codereview.chromium.org/2437383002/ this should be okay now. > > Original issue's description: > > Revert of [Reland] Upgrade to new Android SDK. (patchset #2 id:20001 of https://codereview.chromium.org/2438133002/ ) > > > > Reason for revert: > > forward --list issues + gtest perf test adb locations need to be updated. > > > > Original issue's description: > > > [Reland] Upgrade to new Android SDK. > > > > > > https://codereview.chromium.org/2350013004/ was reverted due to breakage on the perf waterfall. After https://codereview.chromium.org/2438563004/, this should hopefully be resolved. > > > > > > BUG=623989 > > > > > > Committed: https://crrev.com/a8b2a521ccd425935ef26a70e0f65b57de50d788 > > > Cr-Commit-Position: refs/heads/master@{#426777} > > > > TBR=xunjieli@chromium.org,stip@chromium.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=623989 > > > > Committed: https://crrev.com/8397f04a7f49909e445d30ccb8d187fedc7959e2 > > Cr-Commit-Position: refs/heads/master@{#426926} > > TBR=xunjieli@chromium.org,jbudorick@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=623989 > > Committed: https://crrev.com/901c8bdf4512f4c98f553440b27e52fa59c4dc0c > Cr-Commit-Position: refs/heads/master@{#427538} TBR=xunjieli@chromium.org,jbudorick@chromium.org,stip@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=623989

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -124 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M build/android/BUILD.gn View 1 chunk +4 lines, -4 lines 0 comments Download
M build/android/devil_chromium.json View 3 chunks +3 lines, -3 lines 0 comments Download
M build/android/lint/suppressions.xml View 4 chunks +1 line, -98 lines 0 comments Download
M build/android/pylib/constants/__init__.py View 1 chunk +1 line, -1 line 0 comments Download
M build/config/android/config.gni View 1 chunk +2 lines, -2 lines 0 comments Download
M components/cronet/android/api/build.xml View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/tools/generate_javadoc.py View 1 chunk +3 lines, -9 lines 0 comments Download
M docs/android_test_instructions.md View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/android/eclipse/.classpath View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ynovikov
Created Revert of Upgrade to new Android SDK.
4 years, 1 month ago (2016-10-26 02:01:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2452873002/1
4 years, 1 month ago (2016-10-26 02:02:19 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 1 month ago (2016-10-26 02:02:20 UTC) #5
jbudorick
As mentioned offline, please don't land this.
4 years, 1 month ago (2016-10-26 03:44:23 UTC) #6
jbudorick
On 2016/10/26 03:44:23, jbudorick wrote: > As mentioned offline, please don't land this. chromium.gpu.fyi bots ...
4 years, 1 month ago (2016-10-26 15:13:33 UTC) #7
ynovikov
4 years, 1 month ago (2016-10-26 18:31:35 UTC) #8
Message was sent while issue was closed.
On 2016/10/26 15:13:33, jbudorick wrote:
> On 2016/10/26 03:44:23, jbudorick wrote:
> > As mentioned offline, please don't land this.
> 
> chromium.gpu.fyi bots fixed by https://codereview.chromium.org/2453683002/

Thanks!

Powered by Google App Engine
This is Rietveld 408576698