Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2452863003: Fix DNS logging macro that was broken by adding another net priority. (Closed)

Created:
4 years, 1 month ago by mmenke
Modified:
4 years, 1 month ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix DNS logging macro that was broken by adding another net priority. This was broken by https://codereview.chromium.org/1866483002/ BUG=600839, 659338 Committed: https://crrev.com/2f23b702967fc351f90a8274c6df03054fa23234 Cr-Commit-Position: refs/heads/master@{#427874}

Patch Set 1 #

Patch Set 2 : Make debugging easier #

Patch Set 3 : Actually, make new priorities result in a build error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/dns/host_resolver_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (9 generated)
mmenke
Randy, mind giving this one a quick look?
4 years, 1 month ago (2016-10-26 16:10:13 UTC) #3
Randy Smith (Not in Mondays)
Whoops; thank you. LGTM.
4 years, 1 month ago (2016-10-26 17:45:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2452863003/40001
4 years, 1 month ago (2016-10-26 18:00:23 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/325173)
4 years, 1 month ago (2016-10-26 20:17:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2452863003/40001
4 years, 1 month ago (2016-10-26 20:32:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2452863003/40001
4 years, 1 month ago (2016-10-26 21:28:58 UTC) #13
mmenke
On 2016/10/26 20:32:56, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 1 month ago (2016-10-26 21:29:21 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-10-26 23:27:08 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 23:31:44 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2f23b702967fc351f90a8274c6df03054fa23234
Cr-Commit-Position: refs/heads/master@{#427874}

Powered by Google App Engine
This is Rietveld 408576698