Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 2452843002: Change CTS filepath format (Closed)

Created:
4 years, 1 month ago by the real yoland
Modified:
4 years, 1 month ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Change CTS filepath format Having only CTS zip file's path with the build id in the name can be confusing. Adding "_origin" as a comment shows where the cts zip was downloaded from. CL for json change: https://codereview.chromium.org/2450103003 BUG=659072 Committed: https://chromium.googlesource.com/chromium/tools/build/+/f03d1942fdbc7dca854706021ed6aaaaedad67fc

Patch Set 1 #

Patch Set 2 : transitional #

Total comments: 1

Patch Set 3 : minor fix #

Messages

Total messages: 10 (5 generated)
the real yoland
4 years, 1 month ago (2016-10-26 01:10:58 UTC) #2
the real yoland
friendly ping ; )
4 years, 1 month ago (2016-10-27 00:25:15 UTC) #4
mikecase (-- gone --)
lgtm with nit https://codereview.chromium.org/2452843002/diff/20001/scripts/slave/recipe_modules/chromium_android/api.py File scripts/slave/recipe_modules/chromium_android/api.py (right): https://codereview.chromium.org/2452843002/diff/20001/scripts/slave/recipe_modules/chromium_android/api.py#newcode1257 scripts/slave/recipe_modules/chromium_android/api.py:1257: cts_filenames_json.split('\n')) nit: split('\n') --> splitlines()
4 years, 1 month ago (2016-10-27 15:54:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2452843002/40001
4 years, 1 month ago (2016-10-27 17:17:42 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 17:27:21 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/tools/build/+/f03d1942fdbc7dca8547...

Powered by Google App Engine
This is Rietveld 408576698