Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1538)

Unified Diff: chrome/test/data/push_messaging/push_test.js

Issue 2452833004: Fix flaky SW registration in PushMessaging/BudgetManager browser tests (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/push_messaging/push_test.js
diff --git a/chrome/test/data/push_messaging/push_test.js b/chrome/test/data/push_messaging/push_test.js
index 73907ba5f1124e4b56e410bb4b720a00c39f1463..8bd7ebea1e601b48a4379aa6940926212f6e2920 100644
--- a/chrome/test/data/push_messaging/push_test.js
+++ b/chrome/test/data/push_messaging/push_test.js
@@ -48,10 +48,11 @@ function registerServiceWorker() {
// The base dir used to resolve service_worker.js and the scope depends on
// whether this script is included from an html file in ./, subscope1/, or
// subscope2/.
- navigator.serviceWorker.register('service_worker.js', {scope: './'}).then(
- function(swRegistration) {
- sendResultToTest('ok - service worker registered');
- }, sendErrorToTest);
+ navigator.serviceWorker.register('service_worker.js', {
+ scope: './'
+ }).then(swRegistrationReady).then(() => {
+ sendResultToTest('ok - service worker registered');
+ }).catch(sendErrorToTest);
}
function unregisterServiceWorker() {

Powered by Google App Engine
This is Rietveld 408576698