Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2452833003: [promises] Create runtime-promise.cc (Closed)

Created:
4 years, 1 month ago by gsathya
Modified:
4 years, 1 month ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[promises] Create runtime-promise.cc This patch moves promise specific runtime functions to runtime-promise.cc from runtime-internal.cc BUG=v8:5343 Committed: https://crrev.com/b15f8710c638da63f1475317bcbdd25eef3720ed Cr-Commit-Position: refs/heads/master@{#40618}

Patch Set 1 #

Patch Set 2 : adding dependency #

Total comments: 1

Patch Set 3 : update date #

Patch Set 4 : rebase #

Patch Set 5 : fix rebase #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -181 lines) Patch
M BUILD.gn View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-internal.cc View 1 2 3 4 5 3 chunks +0 lines, -181 lines 0 comments Download
A src/runtime/runtime-promise.cc View 1 2 3 4 1 chunk +194 lines, -0 lines 0 comments Download
M src/v8.gyp View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
gsathya
4 years, 1 month ago (2016-10-26 16:10:22 UTC) #4
adamk
lgtm % copyright https://codereview.chromium.org/2452833003/diff/20001/src/runtime/runtime-promise.cc File src/runtime/runtime-promise.cc (right): https://codereview.chromium.org/2452833003/diff/20001/src/runtime/runtime-promise.cc#newcode1 src/runtime/runtime-promise.cc:1: // Copyright 2014 the V8 project ...
4 years, 1 month ago (2016-10-26 16:14:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2452833003/100001
4 years, 1 month ago (2016-10-27 11:58:17 UTC) #15
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 1 month ago (2016-10-27 12:28:06 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:15:25 UTC) #18
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/b15f8710c638da63f1475317bcbdd25eef3720ed
Cr-Commit-Position: refs/heads/master@{#40618}

Powered by Google App Engine
This is Rietveld 408576698