[CUPS] MD Settings: Migrate from paper-dropdown-menu-light to native select

[CUPS] MD Settings: Migrate from paper-dropdown-menu-light to native select

BUG=656807
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/8a6d0114982b49799e7e28d1cd4fe61649ad77e9
Cr-Commit-Position: refs/heads/master@{#427577}

[xdai1, 2016-10-25 23:45:56]

Description was changed from

==========
[CUPS] MD Settings: Migrate from paper-dropdown-menu-light to native select

BUG=656807
==========

to

==========
[CUPS] MD Settings: Migrate from paper-dropdown-menu-light to native select

BUG=656807
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[xdai1, 2016-10-25 23:49:58]

xdai@chromium.org changed reviewers:
+ stevenjb@chromium.org

[xdai1, 2016-10-25 23:49:59]

stevenjb@, could you help review this CL please? Thanks!

[stevenjb, 2016-10-25 23:57:57]

stevenjb@chromium.org changed reviewers:
+ dpapad@chromium.org

[stevenjb, 2016-10-25 23:57:58]

+dpapad@ FYI

Thanks for doing this quickly, lgtm.

[dpapad, 2016-10-26 00:03:06]

https://codereview.chromium.org/2452833002/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html
(right):

https://codereview.chromium.org/2452833002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html:13:
<style include="settings-shared">
The md-select styling is not applied unless you modify this line as follows 

<style include="settings-shared md-select">

Could you attach a screenshot to verify that everything looks as expected?

[stevenjb, 2016-10-26 00:05:19]

https://codereview.chromium.org/2452833002/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html
(right):

https://codereview.chromium.org/2452833002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html:13:
<style include="settings-shared">
On 2016/10/26 00:03:05, dpapad wrote:
> The md-select styling is not applied unless you modify this line as follows 
> 
> <style include="settings-shared md-select">
> 
> Could you attach a screenshot to verify that everything looks as expected?

There are two dom-module instances in this file, md-select is added in line 78.

[dpapad, 2016-10-26 00:05:24]

LGTM

https://codereview.chromium.org/2452833002/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html
(right):

https://codereview.chromium.org/2452833002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html:13:
<style include="settings-shared">
On 2016/10/26 at 00:03:05, dpapad wrote:
> The md-select styling is not applied unless you modify this line as follows 
> 
> <style include="settings-shared md-select">
> 
> Could you attach a screenshot to verify that everything looks as expected?

Ok, ignore my comment. I got confused by the multiple dom-module definitions in
the same file.

[xdai1, 2016-10-26 00:36:04]

The CQ bit was checked by xdai@chromium.org

[commit-bot: I haz the power, 2016-10-26 00:36:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 01:58:11]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-26 02:01:12]

Description was changed from

==========
[CUPS] MD Settings: Migrate from paper-dropdown-menu-light to native select

BUG=656807
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[CUPS] MD Settings: Migrate from paper-dropdown-menu-light to native select

BUG=656807
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/8a6d0114982b49799e7e28d1cd4fe61649ad77e9
Cr-Commit-Position: refs/heads/master@{#427577}
==========

[commit-bot: I haz the power, 2016-10-26 02:01:13]

Patchset 1 (id:??) landed as
https://crrev.com/8a6d0114982b49799e7e28d1cd4fe61649ad77e9
Cr-Commit-Position: refs/heads/master@{#427577}