Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 2452833002: [CUPS] MD Settings: Migrate from paper-dropdown-menu-light to native select (Closed)

Created:
4 years, 1 month ago by xdai1
Modified:
4 years, 1 month ago
Reviewers:
stevenjb, dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[CUPS] MD Settings: Migrate from paper-dropdown-menu-light to native select BUG=656807 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/8a6d0114982b49799e7e28d1cd4fe61649ad77e9 Cr-Commit-Position: refs/heads/master@{#427577}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -25 lines) Patch
M chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html View 3 chunks +17 lines, -25 lines 3 comments Download
M chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.js View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
xdai1
stevenjb@, could you help review this CL please? Thanks!
4 years, 1 month ago (2016-10-25 23:49:59 UTC) #3
stevenjb
+dpapad@ FYI Thanks for doing this quickly, lgtm.
4 years, 1 month ago (2016-10-25 23:57:58 UTC) #5
dpapad
https://codereview.chromium.org/2452833002/diff/1/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html File chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html (right): https://codereview.chromium.org/2452833002/diff/1/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html#newcode13 chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html:13: <style include="settings-shared"> The md-select styling is not applied unless ...
4 years, 1 month ago (2016-10-26 00:03:06 UTC) #6
stevenjb
https://codereview.chromium.org/2452833002/diff/1/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html File chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html (right): https://codereview.chromium.org/2452833002/diff/1/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html#newcode13 chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html:13: <style include="settings-shared"> On 2016/10/26 00:03:05, dpapad wrote: > The ...
4 years, 1 month ago (2016-10-26 00:05:19 UTC) #7
dpapad
LGTM https://codereview.chromium.org/2452833002/diff/1/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html File chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html (right): https://codereview.chromium.org/2452833002/diff/1/chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html#newcode13 chrome/browser/resources/settings/printing_page/cups_add_printer_dialog.html:13: <style include="settings-shared"> On 2016/10/26 at 00:03:05, dpapad wrote: ...
4 years, 1 month ago (2016-10-26 00:05:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2452833002/1
4 years, 1 month ago (2016-10-26 00:36:39 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 01:58:11 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 02:01:13 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8a6d0114982b49799e7e28d1cd4fe61649ad77e9
Cr-Commit-Position: refs/heads/master@{#427577}

Powered by Google App Engine
This is Rietveld 408576698