docs/quickstart.md - Issue 245283002: warn that docs/quickstart.md is out of sync with official docs

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: docs/quickstart.md

Issue 245283002: warn that docs/quickstart.md is out of sync with official docs (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 Skia Quickstart Guide	1 Skia Quickstart Guide

2 =====================	2 =====================

3	3

	4

	5 WARNING: Several steps in this guide are out of sync with our automatically-

	6 tested, officially-supported processes for checking out and building Skia.

	7 The officially supported processes are the ones documented in skiadocs; see

	8 https://sites.google.com/site/skiadocs/user-documentation/quick-start-guides

	9

	10 The steps documented within this file are more experimental in nature.

	11

	12

4 This guide assumes you've got `git`, `ninja`, and `python` on your path.	13 This guide assumes you've got `git`, `ninja`, and `python` on your path.

5	14

6 1. First, checkout Skia:	15 1. First, checkout Skia:

7 * `git clone https://skia.googlesource.com/skia.git`	16 * `git clone https://skia.googlesource.com/skia.git`

8 * `cd skia`	17 * `cd skia`

9 2. Then download the dependencies. You only need to rerun this when	18 2. Then download the dependencies. You only need to rerun this when

10 the dependencies change.	19 the dependencies change.

11 * `python tools/git-sync-deps`	20 * `python tools/git-sync-deps`

12 3. Create our Ninja build files from our Gyp meta-build files. You only need	21 3. Create our Ninja build files from our Gyp meta-build files. You only need

13 to rerun this when you sync or change a `.gyp` file.	22 to rerun this when you sync or change a `.gyp` file.

(...skipping 12 matching lines...) Expand all Loading...
26 * `vim tests/...`	35 * `vim tests/...`

27 * `git commit --amend -a`	36 * `git commit --amend -a`

28 * `ninja -C out/Debug && out/Debug/tests && out/Debug/dm && echo ok`	37 * `ninja -C out/Debug && out/Debug/tests && out/Debug/dm && echo ok`

29 7. Rebase your change onto the latest Skia code:	38 7. Rebase your change onto the latest Skia code:

30 * `git pull --rebase`	39 * `git pull --rebase`

31 * `ninja -C out/Debug && out/Debug/tests && out/Debug/dm && echo ok`	40 * `ninja -C out/Debug && out/Debug/tests && out/Debug/dm && echo ok`

32 8. Upload your change and send it out for review:	41 8. Upload your change and send it out for review:

33 * `git cl upload -r my-skia-reviewer@google.com -s`	42 * `git cl upload -r my-skia-reviewer@google.com -s`

34 * `git cl web`	43 * `git cl web`

35 9. Go through code review, get an LGTM, submit using the checkbox on the code re view page.	44 9. Go through code review, get an LGTM, submit using the checkbox on the code re view page.

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »