Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4305)

Unified Diff: chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkMetaDataUtilsTest.java

Issue 2452823002: Make ManifestUpgradeDetector correctly fetch "icon Murmur2 hash" if hash is big (Closed)
Patch Set: Merge branch 'master' into update_fail_fix_crash1_murmur2_long Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkMetaDataUtilsTest.java
diff --git a/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkMetaDataUtilsTest.java b/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkMetaDataUtilsTest.java
index 7db2c0885649bae1bfe9de1e4b0d823d26ddcb01..96174bd0be718756510d1c6eb70da76974259a16 100644
--- a/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkMetaDataUtilsTest.java
+++ b/chrome/android/junit/src/org/chromium/chrome/browser/webapps/WebApkMetaDataUtilsTest.java
@@ -90,4 +90,18 @@ public class WebApkMetaDataUtilsTest {
WebApkTestHelper.WEBAPK_PACKAGE_NAME, passedInStartUrl, 0);
Assert.assertEquals(passedInStartUrl, webappInfo.uri().toString());
}
+
+ /**
+ * WebApkIconHasher generates hashes with values [0, 2^64-1]. 2^64-1 is greater than
+ * {@link Long#MAX_VALUE}. Test that {@link #getIconMurmur2HashFromMetaData()} can read a hash
+ * with value 2^64 - 1.
+ */
+ @Test
+ public void testGetIconMurmur2HashFromMetaData() {
+ String hash = "18446744073709551615"; // 2^64 - 1
+ Bundle bundle = new Bundle();
+ bundle.putString(WebApkMetaDataKeys.ICON_MURMUR2_HASH, hash + "L");
+ String extractedHash = WebApkMetaDataUtils.getIconMurmur2HashFromMetaData(bundle);
+ Assert.assertEquals(hash, extractedHash);
+ }
}

Powered by Google App Engine
This is Rietveld 408576698