chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetector.java - Issue 2452823002: Make ManifestUpgradeDetector correctly fetch "icon Murmur2 hash" if hash is big

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetector.java

Issue 2452823002: Make ManifestUpgradeDetector correctly fetch "icon Murmur2 hash" if hash is big (Closed)

Patch Set: Merge branch 'master' into update_fail_fix_crash1_murmur2_long Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetector.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetector.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetector.java

index a4dd7d6f6691e999fee425001f878ceb447c3ef7..5d37a2508bc7b73b05f40f8c641299369d604b8b 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetector.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/ManifestUpgradeDetector.java

@@ -115,8 +115,7 @@ public class ManifestUpgradeDetector implements ManifestUpgradeDetectorFetcher.C

mManifestUrl = IntentUtils.safeGetString(metadata, WebApkMetaDataKeys.WEB_MANIFEST_URL);

mStartUrl = IntentUtils.safeGetString(metadata, WebApkMetaDataKeys.START_URL);

mIconUrl = IntentUtils.safeGetString(metadata, WebApkMetaDataKeys.ICON_URL);

- mIconMurmur2Hash = Long.toString(WebApkMetaDataUtils.getLongFromMetaData(

- metadata, WebApkMetaDataKeys.ICON_MURMUR2_HASH, 0));

+ mIconMurmur2Hash = WebApkMetaDataUtils.getIconMurmur2HashFromMetaData(metadata);

}

/**

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkMetaDataUtils.java » ('j') | no next file with comments »