Issue 24528003: Add windows to status variable list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24528003: Add windows to status variable list. (Closed)

Created:
7 years, 2 months ago by Michael Achenbach

Modified:
7 years, 2 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Add windows to status variable list. This will allow to modify test expectation for system==windows. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16941

Patch Set 3 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	tools/testrunner/local/statusfile.py	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
	M	tools/testrunner/local/utils.py	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with comment. https://codereview.chromium.org/24528003/diff/4001/tools/testrunner/local/statusfile.py File tools/testrunner/local/statusfile.py (right): https://codereview.chromium.org/24528003/diff/4001/tools/testrunner/local/statusfile.py#newcode55 tools/testrunner/local/statusfile.py:55: "mipsel", "x64", "nacl_ia32", "nacl_x64", "macos", "win32"]: ...

7 years, 2 months ago (2013-09-25 12:35:48 UTC) #2

Message was sent while issue was closed.

Committed patchset #3 manually as r16941.

Expand Messages | Collapse Messages

Issue 24528003: Add windows to status variable list. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages