[Extensions] Limit Extension WebUI

chrome/browser/extensions/extension_web_ui.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_web_ui.h"
 
 #include <stddef.h>
 
 #include <set>
 #include <utility>
@@ skipping 315 matching lines @@
     callback.Run(list);
   }
 }
 
 }  // namespace
 
 const char ExtensionWebUI::kExtensionURLOverrides[] =
     "extensions.chrome_url_overrides";
 
 ExtensionWebUI::ExtensionWebUI(content::WebUI* web_ui, const GURL& url)
-    : WebUIController(web_ui),
-      url_(url) {
+    : WebUIController(web_ui) {
   Profile* profile = Profile::FromWebUI(web_ui);
   const Extension* extension = extensions::ExtensionRegistry::Get(
       profile)->enabled_extensions().GetExtensionOrAppByURL(url);
   DCHECK(extension);
+  DCHECK_EQ(extension_misc::kBookmarkManagerId, extension->id());
 
   // The base class defaults to enabling WebUI bindings, but we don't need
   // those (this is also reflected in ChromeWebUIControllerFactory::
   // UseWebUIBindingsForURL).
   int bindings = 0;
   web_ui->SetBindings(bindings);
 
   // Hack: A few things we specialize just for the bookmark manager.
-  if (extension->id() == extension_misc::kBookmarkManagerId) {
-    bookmark_manager_private_drag_event_router_.reset(
-        new extensions::BookmarkManagerPrivateDragEventRouter(
-            profile, web_ui->GetWebContents()));
+  bookmark_manager_private_drag_event_router_.reset(
+      new extensions::BookmarkManagerPrivateDragEventRouter(
+          profile, web_ui->GetWebContents()));
 
-    web_ui->SetLinkTransitionType(ui::PAGE_TRANSITION_AUTO_BOOKMARK);
-  }
+  web_ui->SetLinkTransitionType(ui::PAGE_TRANSITION_AUTO_BOOKMARK);
 }
 
 ExtensionWebUI::~ExtensionWebUI() {}
 
-extensions::BookmarkManagerPrivateDragEventRouter*
-ExtensionWebUI::bookmark_manager_private_drag_event_router() {
-  return bookmark_manager_private_drag_event_router_.get();
+// static
+bool ExtensionWebUI::NeedsExtensionWebUI(
+    content::BrowserContext* browser_context,
+    const GURL& url) {
+  CHECK(browser_context);
+  const Extension* extension =
+      extensions::ExtensionRegistry::Get(browser_context)->enabled_extensions().
+          GetExtensionOrAppByURL(url);
+  // Only use bindings for the Bookmark Manager extension, which needs it as a
+  // hack (see ExtensionWebUI's constructor below).
+  return extension && extension->id() == extension_misc::kBookmarkManagerId;
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // chrome:// URL overrides
 
 // static
 void ExtensionWebUI::RegisterProfilePrefs(
     user_prefs::PrefRegistrySyncable* registry) {
   registry->RegisterDictionaryPref(kExtensionURLOverrides);
 }
@@ skipping 186 matching lines @@
         extensions::ImageLoader::ImageRepresentation::ALWAYS_RESIZE,
         gfx::Size(pixel_size, pixel_size),
         resource_scale_factor));
   }
 
   // LoadImagesAsync actually can run callback synchronously. We want to force
   // async.
   extensions::ImageLoader::Get(profile)->LoadImagesAsync(
       extension, info_list, base::Bind(&RunFaviconCallbackAsync, callback));
 }