Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Unified Diff: tools/run-tests.py

Issue 2452763003: [test] Remove verbose output printing on windows. (Closed)
Patch Set: Confusion. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/run-tests.py
diff --git a/tools/run-tests.py b/tools/run-tests.py
index 99ccc6f04e3960657e6a72665ce44b3f9f552be1..b473efe50c2a65bc70f5cabaf383f254249a7a08 100755
--- a/tools/run-tests.py
+++ b/tools/run-tests.py
@@ -757,14 +757,8 @@ def Execute(arch, mode, args, options, suites):
# Predictable mode is slower.
options.timeout *= 2
- # TODO(machenbach): Remove temporary verbose output on windows after
- # debugging driver-hung-up on XP.
- verbose_output = (
- options.verbose or
- utils.IsWindows() and options.progress == "verbose"
- )
ctx = context.Context(arch, MODES[mode]["execution_mode"], shell_dir,
- mode_flags, verbose_output,
+ mode_flags, options.verbose,
options.timeout,
options.isolates,
options.command_prefix,
@@ -875,7 +869,7 @@ def Execute(arch, mode, args, options, suites):
run_networked = not options.no_network
if not run_networked:
- if verbose_output:
+ if options.verbose:
print("Network distribution disabled, running tests locally.")
elif utils.GuessOS() != "linux":
print("Network distribution is only supported on Linux, sorry!")
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698