Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2452753004:
MD Settings: Remove three unused routes. (Closed)
|
Created:
4 years, 1 month ago by tommycli Modified:
4 years, 1 month ago Reviewers:
Dan Beam CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD Settings: Remove three unused routes.
BUG=623587
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/d609c7b042b1e0b2f246d99d692d65d796ba14c0
Cr-Commit-Position: refs/heads/master@{#427817}
Patch Set 1 #
Total comments: 1
Messages
Total messages: 19 (12 generated)
Description was changed from ========== MD Settings: Remove three unused routes. BUG=623587 ========== to ========== MD Settings: Remove three unused routes. BUG=623587 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by tommycli@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
tommycli@chromium.org changed reviewers: + dbeam@chromium.org
dbeam: PTAL, thanks!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm if you grepped or something
On 2016/10/26 19:33:04, Dan Beam wrote: > lgtm if you grepped or something yep! i searched. Thanks!
The CQ bit was checked by tommycli@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
michaelpg@chromium.org changed reviewers: + michaelpg@chromium.org
https://codereview.chromium.org/2452753004/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/route.js (left): https://codereview.chromium.org/2452753004/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/route.js:181: r.LANGUAGES_DETAIL = r.LANGUAGES.createChild('edit'); whoops, thanks!
Description was changed from ========== MD Settings: Remove three unused routes. BUG=623587 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: Remove three unused routes. BUG=623587 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
michaelpg@chromium.org changed reviewers: - michaelpg@chromium.org
Message was sent while issue was closed.
Description was changed from ========== MD Settings: Remove three unused routes. BUG=623587 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: Remove three unused routes. BUG=623587 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== MD Settings: Remove three unused routes. BUG=623587 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: Remove three unused routes. BUG=623587 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/d609c7b042b1e0b2f246d99d692d65d796ba14c0 Cr-Commit-Position: refs/heads/master@{#427817} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/d609c7b042b1e0b2f246d99d692d65d796ba14c0 Cr-Commit-Position: refs/heads/master@{#427817} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
