Chromium Code Reviews
Description[Offline pages] Reinstating the offline icon on tablet and fixing verbose state/URL emphasis
This patch addresses the following problems:
* Offline icon is not shown in omnibox on tablets
* Offline verbose status is sometimes shown with green padlock
* URL emphasis lags behind security icon update.
This fix does the following:
* Moves the offline icon from the navigation button to security button
* Ensures that navigation button is never shown on phones
* Calculates when to show: navigation/security/no button, to properly
show or hide icon container.
* Moves verbose status visibility control to security button related
code (as that is where we show offline stuff and would show verbose
security states)
BUG=656088, 648129
R=tedchoc@chromium.org
Review-Url: https://codereview.chromium.org/2438413002
Cr-Commit-Position: refs/heads/master@{#427209}
(cherry picked from commit 666fbc655654767125b5d2e89cac26b378eb758c)
Committed: https://chromium.googlesource.com/chromium/src/+/d6275b7f774be01f878380c8b934f13fc277686c
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||