Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 2452753003: [Offline pages] Reinstating the offline icon on tablet and fixing verbose state/URL emphasis (Closed)

Created:
4 years, 1 month ago by fgorski
Modified:
4 years, 1 month ago
Reviewers:
Ted C
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

[Offline pages] Reinstating the offline icon on tablet and fixing verbose state/URL emphasis This patch addresses the following problems: * Offline icon is not shown in omnibox on tablets * Offline verbose status is sometimes shown with green padlock * URL emphasis lags behind security icon update. This fix does the following: * Moves the offline icon from the navigation button to security button * Ensures that navigation button is never shown on phones * Calculates when to show: navigation/security/no button, to properly show or hide icon container. * Moves verbose status visibility control to security button related code (as that is where we show offline stuff and would show verbose security states) BUG=656088, 648129 R=tedchoc@chromium.org Review-Url: https://codereview.chromium.org/2438413002 Cr-Commit-Position: refs/heads/master@{#427209} (cherry picked from commit 666fbc655654767125b5d2e89cac26b378eb758c) Committed: https://chromium.googlesource.com/chromium/src/+/d6275b7f774be01f878380c8b934f13fc277686c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -72 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java View 19 chunks +83 lines, -49 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java View 1 chunk +14 lines, -21 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarModelImpl.java View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappUrlBar.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
fgorski
4 years, 1 month ago (2016-10-25 21:24:44 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d6275b7f774be01f878380c8b934f13fc277686c.

Powered by Google App Engine
This is Rietveld 408576698