Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2452723002: cc: Stop creating FBO for read lock on SkImage in Resource Provider (Closed)

Created:
4 years, 1 month ago by weiliangc
Modified:
4 years, 1 month ago
Reviewers:
enne (OOO)
CC:
bsalomon_chromium, cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Stop creating FBO for read lock on SkImage in Resource Provider Since the SkImage is only used for read lock, no need to create FBO. This is used for SkiaRenderer. BUG=644851 R=enne CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/0b17f8c0b9d2ef247a36d66873d55b7cb66fcea8 Cr-Commit-Position: refs/heads/master@{#429322}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M cc/resources/resource_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
weiliangc
One line fix :)
4 years, 1 month ago (2016-10-25 18:37:39 UTC) #4
enne (OOO)
OOPS lgtm
4 years, 1 month ago (2016-10-25 18:47:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2452723002/1
4 years, 1 month ago (2016-11-02 15:28:26 UTC) #9
weiliangc
On 2016/11/02 at 15:28:06, weiliangc wrote: > The CQ bit was checked by weiliangc@chromium.org Oops....
4 years, 1 month ago (2016-11-02 15:28:31 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-02 17:33:59 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 17:56:35 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0b17f8c0b9d2ef247a36d66873d55b7cb66fcea8
Cr-Commit-Position: refs/heads/master@{#429322}

Powered by Google App Engine
This is Rietveld 408576698