[oilpan] Implement accept methods to trace the class hierarchy of SVGElement and all sub-classes.

[oilpan] Implement accept methods to trace the class hierarchy of SVGElement and all sub-classes.

R=ager@chromium.org
BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158320

[Mads Ager (chromium), 2013-09-25 11:16:31]

LGTM

https://codereview.chromium.org/24527003/diff/1/Source/core/svg/SVGElement.h
File Source/core/svg/SVGElement.h (right):

https://codereview.chromium.org/24527003/diff/1/Source/core/svg/SVGElement.h#...
Source/core/svg/SVGElement.h:125: void accept(Visitor*) const;
virtual? OVERRIDE?

[zerny-chromium, 2013-09-25 11:28:34]

https://codereview.chromium.org/24527003/diff/1/Source/core/svg/SVGElement.h
File Source/core/svg/SVGElement.h (right):

https://codereview.chromium.org/24527003/diff/1/Source/core/svg/SVGElement.h#...
Source/core/svg/SVGElement.h:125: void accept(Visitor*) const;
On 2013/09/25 11:16:32, Mads Ager (chromium) wrote:
> virtual? OVERRIDE?

Thanks for spotting that one. Change ended up in a git stash :-)

[zerny-chromium, 2013-09-25 11:35:33]

Committed patchset #1 manually as r158320 (presubmit successful).

[wibling, 2013-09-25 11:44:14]

lgtm2

[haraken, 2013-09-25 14:01:47]

LGTM.

Though it would be better to define the accept methods in .cpp files (We're
doing it in the Node & CSS hierarchy). In the Blink trunk, we're careful about
the binary size for Android builds.

[haraken, 2013-09-25 14:01:47]

LGTM.

Though it would be better to define the accept methods in .cpp files (We're
doing it in the Node & CSS hierarchy). In the Blink trunk, we're careful about
the binary size for Android builds.