Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 2452663002: [NaCl SDK] Remove unneeded headers. (Closed)

Created:
4 years, 1 month ago by chanpatorikku
Modified:
4 years, 1 month ago
Reviewers:
binji, Sam Clegg
CC:
chromium-reviews, binji+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Remove unneeded headers. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_nacl_sdk;master.tryserver.chromium.mac:mac_nacl_sdk;master.tryserver.chromium.win:win_nacl_sdk Committed: https://crrev.com/8ab4e6840a53000878aaee4e4c9405bf1d8d58a4 Cr-Commit-Position: refs/heads/master@{#427930}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M native_client_sdk/src/tests/nacl_io_test/fake_ppapi/fake_pepper_interface_html5_fs.h View 1 chunk +0 lines, -2 lines 0 comments Download
M native_client_sdk/src/tests/nacl_io_test/fake_ppapi/fake_pepper_interface_html5_fs.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
chanpatorikku
There is an Unsent issues category that the issue is in. Some reviewers think an ...
4 years, 1 month ago (2016-10-26 13:36:42 UTC) #3
Sam Clegg
On 2016/10/26 13:36:42, chanpatorikku wrote: > There is an Unsent issues category that the issue ...
4 years, 1 month ago (2016-10-26 15:56:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2452663002/1
4 years, 1 month ago (2016-10-27 02:16:44 UTC) #6
commit-bot: I haz the power
Failed to apply the patch. On branch working_branch Your branch is up-to-date with 'origin/refs/pending/heads/master'. nothing ...
4 years, 1 month ago (2016-10-27 04:02:52 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 04:04:40 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8ab4e6840a53000878aaee4e4c9405bf1d8d58a4
Cr-Commit-Position: refs/heads/master@{#427930}

Powered by Google App Engine
This is Rietveld 408576698