Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 2452653002: [runtime] Fix Object.create(null) initialization order (Closed)

Created:
4 years, 1 month ago by Camillo Bruni
Modified:
4 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Fix Object.create(null) initialization order A GC might cause the just created dictionary object to have an invalid backing store, which breaks heap verification. BUG=chromium:659088 Committed: https://crrev.com/f5d4f8f80f8ca18f1c207c9f0dbc2f478f398fdf Cr-Commit-Position: refs/heads/master@{#40574}

Patch Set 1 #

Total comments: 1

Patch Set 2 : address nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M src/runtime/runtime-object.cc View 1 1 chunk +10 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Camillo Bruni
PTAL
4 years, 1 month ago (2016-10-25 15:33:26 UTC) #2
Jakob Kummerow
LGTM with nit. https://codereview.chromium.org/2452653002/diff/1/src/runtime/runtime-object.cc File src/runtime/runtime-object.cc (right): https://codereview.chromium.org/2452653002/diff/1/src/runtime/runtime-object.cc#newcode253 src/runtime/runtime-object.cc:253: // Allocate the actual dictionay properties ...
4 years, 1 month ago (2016-10-25 19:41:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2452653002/20001
4 years, 1 month ago (2016-10-26 06:53:03 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-26 07:17:08 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:13:07 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f5d4f8f80f8ca18f1c207c9f0dbc2f478f398fdf
Cr-Commit-Position: refs/heads/master@{#40574}

Powered by Google App Engine
This is Rietveld 408576698