Avoid parsing formal type parameters a second time from inside an async body,

Avoid parsing formal type parameters a second time from inside an async body,
as default values may not be resolved correctly and may conflict with already
parsed formal parameters (fixes #27659).
Added regression test.

R=hausner@google.com

Committed: https://github.com/dart-lang/sdk/commit/3342380ff8f628768076fef66679ea3754d2e883

[regis, 2016-10-25 13:29:28]

regis@google.com changed reviewers:
+ asiva@google.com, hausner@google.com

[hausner, 2016-10-25 15:04:55]

lgtm

https://codereview.chromium.org/2452623002/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/2452623002/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:11249: expr->EvalConstExpr();
Why do you evaluate the expression a second time? Left-over debugging code?

[regis, 2016-10-25 15:08:46]

Thanks!

https://codereview.chromium.org/2452623002/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/2452623002/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:11249: expr->EvalConstExpr();
On 2016/10/25 15:04:55, hausner wrote:
> Why do you evaluate the expression a second time? Left-over debugging code?

Oops. Let's blame it on the jetlag.
Removed. Thanks!

[regis, 2016-10-25 15:11:43]

Description was changed from

==========
Avoid parsing formal type parameters a second time from inside an async body,
as default values may not be resolved correctly and may conflict with already
parsed formal parameters (fixes #27659).
Added regression test.
==========

to

==========
Avoid parsing formal type parameters a second time from inside an async body,
as default values may not be resolved correctly and may conflict with already
parsed formal parameters (fixes #27659).
Added regression test.

R=hausner@google.com

Committed:
https://github.com/dart-lang/sdk/commit/3342380ff8f628768076fef66679ea3754d2e883
==========

[regis, 2016-10-25 15:11:44]

Committed patchset #2 (id:20001) manually as
3342380ff8f628768076fef66679ea3754d2e883 (presubmit successful).