Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2452603002:
Modernize ref_counted.h (Closed)
DescriptionModernize ref_counted.h
BUG=653916
Committed: https://crrev.com/f70feba7ac930067d834d7cdafc68cdc048979b0
Cr-Commit-Position: refs/heads/master@{#428104}
Patch Set 1 #Patch Set 2 : fix compile #
Total comments: 4
Patch Set 3 : init ptr_ at defn-site #Patch Set 4 : Add RefCountedThreadSafe to OpaqueRefCounted tests #Patch Set 5 : back to PS 2 -- will follow-up with rest #
Dependent Patchsets: Messages
Total messages: 25 (15 generated)
The CQ bit was checked by gab@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
gab@chromium.org changed reviewers: + danakj@chromium.org
Dana PTAL, a little cleanup I just split from the precursor to https://codereview.chromium.org/2443103003/#msg18 I'm writting up now.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
The CQ bit was checked by gab@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM https://codereview.chromium.org/2452603002/diff/20001/base/memory/ref_counted.h File base/memory/ref_counted.h (right): https://codereview.chromium.org/2452603002/diff/20001/base/memory/ref_counted... base/memory/ref_counted.h:272: scoped_refptr() : ptr_(nullptr) { i think do this at the site of defn https://codereview.chromium.org/2452603002/diff/20001/base/memory/ref_counted... base/memory/ref_counted.h:383: T* ptr_; = nullptr
Good point, done. https://codereview.chromium.org/2452603002/diff/20001/base/memory/ref_counted.h File base/memory/ref_counted.h (right): https://codereview.chromium.org/2452603002/diff/20001/base/memory/ref_counted... base/memory/ref_counted.h:272: scoped_refptr() : ptr_(nullptr) { On 2016/10/25 20:29:18, danakj wrote: > i think do this at the site of defn Done. https://codereview.chromium.org/2452603002/diff/20001/base/memory/ref_counted... base/memory/ref_counted.h:383: T* ptr_; On 2016/10/25 20:29:18, danakj wrote: > = nullptr Done.
The CQ bit was checked by gab@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org Link to the patchset: https://codereview.chromium.org/2452603002/#ps40001 (title: "init ptr_ at defn-site")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
On 2016/10/26 16:21:04, gab wrote: > Good point, done. > > https://codereview.chromium.org/2452603002/diff/20001/base/memory/ref_counted.h > File base/memory/ref_counted.h (right): > > https://codereview.chromium.org/2452603002/diff/20001/base/memory/ref_counted... > base/memory/ref_counted.h:272: scoped_refptr() : ptr_(nullptr) { > On 2016/10/25 20:29:18, danakj wrote: > > i think do this at the site of defn > > Done. > > https://codereview.chromium.org/2452603002/diff/20001/base/memory/ref_counted... > base/memory/ref_counted.h:383: T* ptr_; > On 2016/10/25 20:29:18, danakj wrote: > > = nullptr > > Done. FYI, having subtle issue with = default compiler. Tweaking some things but will move that to a follow-up CL, landing PS2 as it was.
The CQ bit was checked by gab@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org Link to the patchset: https://codereview.chromium.org/2452603002/#ps80001 (title: "back to PS 2 -- will follow-up with rest")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/10/27 15:23:50, gab wrote: > On 2016/10/26 16:21:04, gab wrote: > > Good point, done. > > > > > https://codereview.chromium.org/2452603002/diff/20001/base/memory/ref_counted.h > > File base/memory/ref_counted.h (right): > > > > > https://codereview.chromium.org/2452603002/diff/20001/base/memory/ref_counted... > > base/memory/ref_counted.h:272: scoped_refptr() : ptr_(nullptr) { > > On 2016/10/25 20:29:18, danakj wrote: > > > i think do this at the site of defn > > > > Done. > > > > > https://codereview.chromium.org/2452603002/diff/20001/base/memory/ref_counted... > > base/memory/ref_counted.h:383: T* ptr_; > > On 2016/10/25 20:29:18, danakj wrote: > > > = nullptr > > > > Done. > > FYI, having subtle issue with = default compiler. Tweaking some things but will > move that to a follow-up CL, landing PS2 as it was. @ https://codereview.chromium.org/2446403006/#
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Modernize ref_counted.h BUG=653916 ========== to ========== Modernize ref_counted.h BUG=653916 Committed: https://crrev.com/f70feba7ac930067d834d7cdafc68cdc048979b0 Cr-Commit-Position: refs/heads/master@{#428104} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/f70feba7ac930067d834d7cdafc68cdc048979b0 Cr-Commit-Position: refs/heads/master@{#428104} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
