chrome/browser/android/offline_pages/offline_page_request_job.cc - Issue 2452593003: Fix incorrectly reported UMA OfflinePages.AggregatedRequestResult

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/offline_page_request_job.cc

Issue 2452593003: Fix incorrectly reported UMA OfflinePages.AggregatedRequestResult (Closed)

Patch Set: Address feedback Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/offline_pages/offline_page_request_job.cc

diff --git a/chrome/browser/android/offline_pages/offline_page_request_job.cc b/chrome/browser/android/offline_pages/offline_page_request_job.cc

index 5f161416f40d0223d35eaf4c058085e8962459ee..59d52cb5ca505d93357b6c6c7fac9c3f51f5fd25 100644

--- a/chrome/browser/android/offline_pages/offline_page_request_job.cc

+++ b/chrome/browser/android/offline_pages/offline_page_request_job.cc

@@ -434,7 +434,7 @@ void SelectPage(

// static

void OfflinePageRequestJob::ReportAggregatedRequestResult(

AggregatedRequestResult result) {

- UMA_HISTOGRAM_ENUMERATION("OfflinePages.AggregatedRequestResult",

+ UMA_HISTOGRAM_ENUMERATION("OfflinePages.AggregatedRequestResult2",

static_cast<int>(result),

static_cast<int>(AggregatedRequestResult::AGGREGATED_REQUEST_RESULT_MAX));

}