Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 2452593003: Fix incorrectly reported UMA OfflinePages.AggregatedRequestResult (Closed)
Patch Set: Address feedback Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « chrome/browser/android/offline_pages/offline_page_tab_helper.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index cb5a22c353dc48c7af68706e9ee22d107526f85a..121e95b5a80ca00214dae0061107ec330fdce226 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -38790,6 +38790,16 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<histogram name="OfflinePages.AggregatedRequestResult"
enum="OfflinePagesAggregatedRequestResult">
+ <obsolete>
+ Deprecated 2016-10, and replaced by OfflinePages.AggregatedRequestResult2.
+ </obsolete>
+ <owner>dimich@chromium.org</owner>
+ <owner>jianli@chromium.org</owner>
+ <summary>Result of servicing requests that may contain offline page.</summary>
+</histogram>
+
+<histogram name="OfflinePages.AggregatedRequestResult2"
+ enum="OfflinePagesAggregatedRequestResult2">
<owner>dimich@chromium.org</owner>
<owner>jianli@chromium.org</owner>
<summary>Result of servicing requests that may contain offline page.</summary>
@@ -92588,6 +92598,9 @@ value.
</enum>
<enum name="OfflinePagesAggregatedRequestResult" type="int">
+ <obsolete>
+ Deprecated 2016-10.
+ </obsolete>
<int value="0" label="Show offline page on disconnected network"/>
<int value="1" label="Page not found on disconnected network"/>
<int value="2" label="Show offline page on flaky network"/>
@@ -92602,6 +92615,21 @@ value.
<int value="11" label="Unknown net error, showing error page"/>
</enum>
+<enum name="OfflinePagesAggregatedRequestResult2" type="int">
Steven Holte 2016/10/26 21:41:04 This definition looks exactly the same as the old
jianli 2016/10/26 22:22:01 The label for value 7 and 8 have been updated due
+ <int value="0" label="Show offline page on disconnected network"/>
+ <int value="1" label="Page not found on disconnected network"/>
+ <int value="2" label="Show offline page on flaky network"/>
+ <int value="3" label="Page not found on flaky network"/>
+ <int value="4" label="Show offline page on prohibitively slow network"/>
+ <int value="5" label="Page not found on prohibitively slow network"/>
+ <int value="6" label="Page not fresh on prohibitively slow network"/>
+ <int value="7" label="Show offline page on connected network"/>
+ <int value="8" label="Page not found on connected network"/>
+ <int value="9" label="Android Tab does not have persistent ID"/>
+ <int value="10" label="No web contents"/>
+ <int value="11" label="Unknown net error, showing error page"/>
+</enum>
+
<enum name="OfflinePagesBackgroundImmediateStartStatus" type="int">
<int value="0" label="Started"/>
<int value="1" label="Busy"/>
« no previous file with comments | « chrome/browser/android/offline_pages/offline_page_tab_helper.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698