Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2452563002: Create runtime type in new space and canonicalize to old space (fixes #27663). (Closed)

Created:
4 years, 1 month ago by regis
Modified:
4 years, 1 month ago
Reviewers:
rmacnak, siva, hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org, siva
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Create runtime type in new space and canonicalize to old space (fixes #27663). R=asiva@google.com, hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/6418f8f36caf4f6af2f575c2f1a7ca828d82ee00

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M runtime/vm/object.cc View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
regis
4 years, 1 month ago (2016-10-25 09:38:07 UTC) #2
siva
lgtm
4 years, 1 month ago (2016-10-25 10:36:46 UTC) #4
hausner
lgtm
4 years, 1 month ago (2016-10-25 10:46:18 UTC) #6
regis
Thanks you both! Siva, I looked at asserting that a non-canonical type would always be ...
4 years, 1 month ago (2016-10-25 11:54:43 UTC) #7
regis
4 years, 1 month ago (2016-10-25 11:56:55 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6418f8f36caf4f6af2f575c2f1a7ca828d82ee00 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698