Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2452553004: Convert editing/pasteboard/copy-text-with-backgroundcolor.html .html to utilize w3c test harness (Closed)

Created:
4 years, 1 month ago by yosin_UTC9
Modified:
4 years, 1 month ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/pasteboard/copy-text-with-backgroundcolor.html .html to utilize w3c test harness This patch converts "copy-text-with-backgroundcolor.html" to utilize w3c test harness with |assert_selection()| to simplify test case for improving code health. This patch is a preparation of http://crrev.com/1958093002 BUG=625533 TEST=n/a; no behavior changes Committed: https://crrev.com/cb7f34f1ddb79c7271d36a9a15a9ab295b41ee4d Cr-Commit-Position: refs/heads/master@{#427653}

Patch Set 1 : 2016-10-26T15:59:55 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -140 lines) Patch
M third_party/WebKit/LayoutTests/editing/pasteboard/copy-text-with-backgroundcolor.html View 1 chunk +77 lines, -71 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/pasteboard/copy-text-with-backgroundcolor-expected.txt View 1 chunk +0 lines, -69 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
yosin_UTC9
PTAL
4 years, 1 month ago (2016-10-26 07:53:01 UTC) #5
Xiaocheng
The converted tests look fine by themselves, but do not seem to be equivalent to ...
4 years, 1 month ago (2016-10-26 09:20:13 UTC) #8
yosin_UTC9
On 2016/10/26 at 09:20:13, xiaochengh wrote: > The converted tests look fine by themselves, but ...
4 years, 1 month ago (2016-10-26 09:42:45 UTC) #9
Xiaocheng
lgtm
4 years, 1 month ago (2016-10-26 09:48:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2452553004/1
4 years, 1 month ago (2016-10-26 09:49:27 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 09:54:20 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 09:55:40 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cb7f34f1ddb79c7271d36a9a15a9ab295b41ee4d
Cr-Commit-Position: refs/heads/master@{#427653}

Powered by Google App Engine
This is Rietveld 408576698