Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(864)

Unified Diff: src/wasm/wasm-module.cc

Issue 2452543003: Don't wrap roots in Handle just to dereference immediately. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/type-feedback-vector.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/wasm/wasm-module.cc
diff --git a/src/wasm/wasm-module.cc b/src/wasm/wasm-module.cc
index fd83e8aa53fc2894553719b1b2bcdc7d74703309..7bc382600051d64fd7ecb84818174cf2edca4ba6 100644
--- a/src/wasm/wasm-module.cc
+++ b/src/wasm/wasm-module.cc
@@ -943,7 +943,8 @@ class WasmInstanceBuilder {
JS_OBJECT_TYPE,
JSObject::kHeaderSize + kWasmInstanceInternalFieldCount * kPointerSize);
Handle<JSObject> instance = factory->NewJSObjectFromMap(map, TENURED);
- instance->SetInternalField(kWasmMemObject, *factory->undefined_value());
+ instance->SetInternalField(kWasmMemObject,
+ isolate_->heap()->undefined_value());
//--------------------------------------------------------------------------
// Set up the globals for the new instance.
@@ -962,7 +963,7 @@ class WasmInstanceBuilder {
Address old_address = owner.is_null()
? nullptr
: GetGlobalStartAddressFromCodeTemplate(
- *factory->undefined_value(),
+ isolate_->heap()->undefined_value(),
JSObject::cast(*owner.ToHandleChecked()));
RelocateGlobals(code_table, old_address,
static_cast<Address>(global_buffer->backing_store()));
« no previous file with comments | « src/type-feedback-vector.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698