Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Side by Side Diff: src/bootstrapper.cc

Issue 2452543003: Don't wrap roots in Handle just to dereference immediately. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ast/scopeinfo.cc ('k') | src/builtins/builtins-error.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/bootstrapper.h" 5 #include "src/bootstrapper.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/api-natives.h" 8 #include "src/api-natives.h"
9 #include "src/base/ieee754.h" 9 #include "src/base/ieee754.h"
10 #include "src/code-stubs.h" 10 #include "src/code-stubs.h"
(...skipping 4524 matching lines...) Expand 10 before | Expand all | Expand 10 after
4535 global_proxy_map->set_is_access_check_needed(true); 4535 global_proxy_map->set_is_access_check_needed(true);
4536 global_proxy_map->set_is_callable(); 4536 global_proxy_map->set_is_callable();
4537 global_proxy_map->set_is_constructor(true); 4537 global_proxy_map->set_is_constructor(true);
4538 global_proxy_map->set_has_hidden_prototype(true); 4538 global_proxy_map->set_has_hidden_prototype(true);
4539 4539
4540 Handle<String> global_name = factory()->global_string(); 4540 Handle<String> global_name = factory()->global_string();
4541 global_proxy_function->shared()->set_instance_class_name(*global_name); 4541 global_proxy_function->shared()->set_instance_class_name(*global_name);
4542 factory()->ReinitializeJSGlobalProxy(global_proxy, global_proxy_function); 4542 factory()->ReinitializeJSGlobalProxy(global_proxy, global_proxy_function);
4543 4543
4544 // HookUpGlobalProxy. 4544 // HookUpGlobalProxy.
4545 global_proxy->set_native_context(*factory()->null_value()); 4545 global_proxy->set_native_context(heap()->null_value());
4546 4546
4547 // DetachGlobal. 4547 // DetachGlobal.
4548 JSObject::ForceSetPrototype(global_proxy, factory()->null_value()); 4548 JSObject::ForceSetPrototype(global_proxy, factory()->null_value());
4549 4549
4550 global_proxy_ = global_proxy; 4550 global_proxy_ = global_proxy;
4551 } 4551 }
4552 4552
4553 // Support for thread preemption. 4553 // Support for thread preemption.
4554 4554
4555 // Reserve space for statics needing saving and restoring. 4555 // Reserve space for statics needing saving and restoring.
(...skipping 17 matching lines...) Expand all
4573 } 4573 }
4574 4574
4575 4575
4576 // Called when the top-level V8 mutex is destroyed. 4576 // Called when the top-level V8 mutex is destroyed.
4577 void Bootstrapper::FreeThreadResources() { 4577 void Bootstrapper::FreeThreadResources() {
4578 DCHECK(!IsActive()); 4578 DCHECK(!IsActive());
4579 } 4579 }
4580 4580
4581 } // namespace internal 4581 } // namespace internal
4582 } // namespace v8 4582 } // namespace v8
OLDNEW
« no previous file with comments | « src/ast/scopeinfo.cc ('k') | src/builtins/builtins-error.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698