Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2452543002:
Roll cros_system_api for authpolicy constants (Closed)
|
Created:
4 years, 1 month ago by ljusten (tachyonic) Modified:
4 years, 1 month ago CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll cros_system_api for authpolicy and login manager constants
Roll cros_system_api to depend on https://chromium.googlesource.com/chromiumos/platform/system_api/+/04ffa5a6f8cc773df1d8cbd4cb136164a9163543.
BUG=658655
TEST=compiles and constants show up
Committed: https://crrev.com/f3bc1ea5ade68e43c4faa07386ee46f94c705513
Cr-Commit-Position: refs/heads/master@{#427363}
Patch Set 1 #Messages
Total messages: 18 (11 generated)
ljusten@chromium.org changed reviewers: + rsorokin@chromium.org
PTAL.
Description was changed from ========== Roll cros_system_api for authpolicy constants Roll cros_system_api to depend on https://chromium.googlesource.com/chromiumos/platform/system_api/+/04ffa5a6f8.... BUG=653509 TEST=compiles and constants show up ========== to ========== Roll cros_system_api for authpolicy constants Roll cros_system_api to depend on https://chromium.googlesource.com/chromiumos/platform/system_api/+/04ffa5a6f8.... BUG=658655 TEST=compiles and constants show up ==========
Description was changed from ========== Roll cros_system_api for authpolicy constants Roll cros_system_api to depend on https://chromium.googlesource.com/chromiumos/platform/system_api/+/04ffa5a6f8.... BUG=658655 TEST=compiles and constants show up ========== to ========== Roll cros_system_api for authpolicy and login manager constants Roll cros_system_api to depend on https://chromium.googlesource.com/chromiumos/platform/system_api/+/04ffa5a6f8.... BUG=658655 TEST=compiles and constants show up ==========
The CQ bit was checked by rsorokin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm Thiemo, could you take a look? Is it ok to roll out dependencies like that? E.g. couple chages are not rolled out yet, and we will roll it out with the commit.
rsorokin@chromium.org changed reviewers: + tnagel@chromium.org
See previous message
lgtm, the changes seem to be limited to adding or removing constants. If that was to break something, the try bots would have noticed.
The CQ bit was checked by rsorokin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Roll cros_system_api for authpolicy and login manager constants Roll cros_system_api to depend on https://chromium.googlesource.com/chromiumos/platform/system_api/+/04ffa5a6f8.... BUG=658655 TEST=compiles and constants show up ========== to ========== Roll cros_system_api for authpolicy and login manager constants Roll cros_system_api to depend on https://chromium.googlesource.com/chromiumos/platform/system_api/+/04ffa5a6f8.... BUG=658655 TEST=compiles and constants show up ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Roll cros_system_api for authpolicy and login manager constants Roll cros_system_api to depend on https://chromium.googlesource.com/chromiumos/platform/system_api/+/04ffa5a6f8.... BUG=658655 TEST=compiles and constants show up ========== to ========== Roll cros_system_api for authpolicy and login manager constants Roll cros_system_api to depend on https://chromium.googlesource.com/chromiumos/platform/system_api/+/04ffa5a6f8.... BUG=658655 TEST=compiles and constants show up Committed: https://crrev.com/f3bc1ea5ade68e43c4faa07386ee46f94c705513 Cr-Commit-Position: refs/heads/master@{#427363} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/f3bc1ea5ade68e43c4faa07386ee46f94c705513 Cr-Commit-Position: refs/heads/master@{#427363} |
