Always count rendered frames; fixes drop flakiness.

Always count rendered frames; fixes drop flakiness.

Not adding to the render count when a frame is rendered just makes
handling dropped frames tricky and flaky. Instead the only thing we
really care about is not carrying forward overage to the next frame
after rendering starts (or restarts).

BUG=656231
TEST=new unittest.

Committed: https://crrev.com/71bec519151a602e5a9334d420c12b1f3f9301f1
Cr-Commit-Position: refs/heads/master@{#428267}

[DaleCurtis, 2016-10-26 19:35:46]

dalecurtis@chromium.org changed reviewers:
+ xhwang@chromium.org

[xhwang, 2016-10-27 21:25:56]

LGTM with a question in the test.

https://codereview.chromium.org/2452523004/diff/1/media/filters/video_rendere...
File media/filters/video_renderer_algorithm.cc (right):

https://codereview.chromium.org/2452523004/diff/1/media/filters/video_rendere...
media/filters/video_renderer_algorithm.cc:81: // If time stops, we should recent
the first_frame_ marker, since we can no
s/recent/reset?

https://codereview.chromium.org/2452523004/diff/1/media/filters/video_rendere...
File media/filters/video_renderer_algorithm_unittest.cc (right):

https://codereview.chromium.org/2452523004/diff/1/media/filters/video_rendere...
media/filters/video_renderer_algorithm_unittest.cc:576: // dropped.
sorry, I don't understand this comment. It seems the DisplayCount() remained the
same?

[DaleCurtis, 2016-10-27 21:56:51]

The CQ bit was checked by dalecurtis@chromium.org

[DaleCurtis, 2016-10-27 21:56:52]

https://codereview.chromium.org/2452523004/diff/1/media/filters/video_rendere...
File media/filters/video_renderer_algorithm.cc (right):

https://codereview.chromium.org/2452523004/diff/1/media/filters/video_rendere...
media/filters/video_renderer_algorithm.cc:81: // If time stops, we should recent
the first_frame_ marker, since we can no
On 2016/10/27 at 21:25:56, xhwang wrote:
> s/recent/reset?

Done.

https://codereview.chromium.org/2452523004/diff/1/media/filters/video_rendere...
File media/filters/video_renderer_algorithm_unittest.cc (right):

https://codereview.chromium.org/2452523004/diff/1/media/filters/video_rendere...
media/filters/video_renderer_algorithm_unittest.cc:576: // dropped.
On 2016/10/27 at 21:25:56, xhwang wrote:
> sorry, I don't understand this comment. It seems the DisplayCount() remained
the same?

Whoops, stale comments. Fixed.

[DaleCurtis, 2016-10-27 21:56:53]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org
Link to the patchset: https://codereview.chromium.org/2452523004/#ps20001
(title: "Update comments.")

[commit-bot: I haz the power, 2016-10-27 21:57:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 23:37:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 23:37:42]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[DaleCurtis, 2016-10-28 00:05:46]

The CQ bit was checked by dalecurtis@chromium.org

[DaleCurtis, 2016-10-28 00:05:47]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org
Link to the patchset: https://codereview.chromium.org/2452523004/#ps40001
(title: "Revert zero-check from OnLastFrameDropped(). Add test.")

[commit-bot: I haz the power, 2016-10-28 00:06:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 01:28:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 01:28:26]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[DaleCurtis, 2016-10-28 02:42:41]

The CQ bit was checked by dalecurtis@chromium.org

[commit-bot: I haz the power, 2016-10-28 02:43:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 03:17:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-28 03:26:23]

Description was changed from

==========
Always count rendered frames; fixes drop flakiness.

Not adding to the render count when a frame is rendered just makes
handling dropped frames tricky and flaky. Instead the only thing we
really care about is not carrying forward overage to the next frame
after rendering starts (or restarts).

BUG=656231
TEST=new unittest.
==========

to

==========
Always count rendered frames; fixes drop flakiness.

Not adding to the render count when a frame is rendered just makes
handling dropped frames tricky and flaky. Instead the only thing we
really care about is not carrying forward overage to the next frame
after rendering starts (or restarts).

BUG=656231
TEST=new unittest.

Committed: https://crrev.com/71bec519151a602e5a9334d420c12b1f3f9301f1
Cr-Commit-Position: refs/heads/master@{#428267}
==========

[commit-bot: I haz the power, 2016-10-28 03:26:24]

Patchset 3 (id:??) landed as
https://crrev.com/71bec519151a602e5a9334d420c12b1f3f9301f1
Cr-Commit-Position: refs/heads/master@{#428267}