Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 2452523003: Sending local data avoid derefing null if the local provider no longer has data. (Closed)

Created:
4 years, 1 month ago by skym
Modified:
4 years, 1 month ago
Reviewers:
maxbogue
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sending local data avoid derefing null if the local provider no longer has data. BUG=659199 Committed: https://crrev.com/5f4ce13727c8054995dc2fb2cd510b706107907c Cr-Commit-Position: refs/heads/master@{#427691}

Patch Set 1 #

Patch Set 2 : This time without changing pulse delay to 1 second. #

Patch Set 3 : Fixing DeviceInfoServiceTest.MergeWithData #

Patch Set 4 : Fixing DeviceInfoServiceTest.MergeWithData #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -25 lines) Patch
M components/sync/device_info/device_info_service.cc View 1 chunk +19 lines, -14 lines 0 comments Download
M components/sync/device_info/device_info_service_unittest.cc View 1 2 9 chunks +38 lines, -11 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
skym
Anything that addresses the fundamental problems, and crbug.com/659263, is ballooning in scope. I wanted this ...
4 years, 1 month ago (2016-10-25 23:08:05 UTC) #6
skym
Unit test fixed!
4 years, 1 month ago (2016-10-25 23:33:14 UTC) #10
maxbogue
lgtm
4 years, 1 month ago (2016-10-26 15:02:21 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2452523003/60001
4 years, 1 month ago (2016-10-26 15:03:03 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-10-26 15:07:42 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 15:10:58 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/5f4ce13727c8054995dc2fb2cd510b706107907c
Cr-Commit-Position: refs/heads/master@{#427691}

Powered by Google App Engine
This is Rietveld 408576698