Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1536)

Unified Diff: content/renderer/render_thread_impl.cc

Issue 2452483002: Move GpuMemoryBufferManager and SharedBitmapManager to CompositorFrameSink (Closed)
Patch Set: review comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_thread_impl.cc
diff --git a/content/renderer/render_thread_impl.cc b/content/renderer/render_thread_impl.cc
index 6ca91bed3a272b90adb6bde4aa7d0e2ec2715f07..56efd7b9afb0730f68c773af873de15a00dac141 100644
--- a/content/renderer/render_thread_impl.cc
+++ b/content/renderer/render_thread_impl.cc
@@ -1940,7 +1940,8 @@ RenderThreadImpl::CreateCompositorFrameSink(
RenderWidgetMusConnection::GetOrCreate(routing_id);
scoped_refptr<gpu::GpuChannelHost> gpu_channel_host =
EstablishGpuChannelSync();
- return connection->CreateCompositorFrameSink(std::move(gpu_channel_host));
+ return connection->CreateCompositorFrameSink(std::move(gpu_channel_host),
+ GetGpuMemoryBufferManager());
}
#endif
@@ -1978,8 +1979,8 @@ RenderThreadImpl::CreateCompositorFrameSink(
DCHECK(!layout_test_mode());
return base::MakeUnique<RendererCompositorFrameSink>(
routing_id, compositor_frame_sink_id,
- CreateExternalBeginFrameSource(routing_id), nullptr, nullptr,
- std::move(frame_swap_message_queue));
+ CreateExternalBeginFrameSource(routing_id), nullptr, nullptr, nullptr,
+ shared_bitmap_manager(), std::move(frame_swap_message_queue));
}
scoped_refptr<ContextProviderCommandBuffer> worker_context_provider =
@@ -2024,14 +2025,15 @@ RenderThreadImpl::CreateCompositorFrameSink(
if (layout_test_deps_) {
return layout_test_deps_->CreateCompositorFrameSink(
routing_id, std::move(gpu_channel_host), std::move(context_provider),
- std::move(worker_context_provider), this);
+ std::move(worker_context_provider), GetGpuMemoryBufferManager(),
+ this);
}
#if defined(OS_ANDROID)
if (sync_compositor_message_filter_) {
return base::MakeUnique<SynchronousCompositorFrameSink>(
std::move(context_provider), std::move(worker_context_provider),
- routing_id, compositor_frame_sink_id,
+ GetGpuMemoryBufferManager(), routing_id, compositor_frame_sink_id,
CreateExternalBeginFrameSource(routing_id),
sync_compositor_message_filter_.get(),
std::move(frame_swap_message_queue));
@@ -2040,7 +2042,8 @@ RenderThreadImpl::CreateCompositorFrameSink(
return base::WrapUnique(new RendererCompositorFrameSink(
routing_id, compositor_frame_sink_id,
CreateExternalBeginFrameSource(routing_id), std::move(context_provider),
- std::move(worker_context_provider), std::move(frame_swap_message_queue)));
+ std::move(worker_context_provider), GetGpuMemoryBufferManager(),
+ nullptr, std::move(frame_swap_message_queue)));
}
AssociatedInterfaceRegistry*

Powered by Google App Engine
This is Rietveld 408576698