Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: runtime/vm/assembler_mips.cc

Issue 2452453002: Support unaligned integer loads on ARM and MIPS. (Closed)
Patch Set: review Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_mips.h ('k') | runtime/vm/assembler_mips_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_mips.cc
diff --git a/runtime/vm/assembler_mips.cc b/runtime/vm/assembler_mips.cc
index aa8905ef1b243a344acbd16b84d315f007894c9a..281a155f6728d96c74c46c8506ad4c2db8f2b0c0 100644
--- a/runtime/vm/assembler_mips.cc
+++ b/runtime/vm/assembler_mips.cc
@@ -1236,6 +1236,18 @@ Address Assembler::ElementAddressForIntIndex(bool is_external,
}
+void Assembler::LoadElementAddressForIntIndex(Register address,
+ bool is_external,
+ intptr_t cid,
+ intptr_t index_scale,
+ Register array,
+ intptr_t index) {
+ const int64_t offset = index * index_scale +
+ (is_external ? 0 : (Instance::DataOffsetFor(cid) - kHeapObjectTag));
+ AddImmediate(address, array, offset);
+}
+
+
Address Assembler::ElementAddressForRegIndex(bool is_load,
bool is_external,
intptr_t cid,
@@ -1264,6 +1276,92 @@ Address Assembler::ElementAddressForRegIndex(bool is_load,
}
+void Assembler::LoadElementAddressForRegIndex(Register address,
+ bool is_load,
+ bool is_external,
+ intptr_t cid,
+ intptr_t index_scale,
+ Register array,
+ Register index) {
+ // Note that index is expected smi-tagged, (i.e, LSL 1) for all arrays.
+ const intptr_t shift = Utils::ShiftForPowerOfTwo(index_scale) - kSmiTagShift;
+ const int32_t offset =
+ is_external ? 0 : (Instance::DataOffsetFor(cid) - kHeapObjectTag);
+ if (shift < 0) {
+ ASSERT(shift == -1);
+ sra(address, index, 1);
+ addu(address, array, address);
+ } else if (shift == 0) {
+ addu(address, array, index);
+ } else {
+ sll(address, index, shift);
+ addu(address, array, address);
+ }
+ if (offset != 0) {
+ AddImmediate(address, offset);
+ }
+}
+
+
+void Assembler::LoadHalfWordUnaligned(Register dst,
+ Register addr,
+ Register tmp) {
+ ASSERT(dst != addr);
+ lbu(dst, Address(addr, 0));
+ lb(tmp, Address(addr, 1));
+ sll(tmp, tmp, 8);
+ or_(dst, dst, tmp);
+}
+
+
+void Assembler::LoadHalfWordUnsignedUnaligned(Register dst,
+ Register addr,
+ Register tmp) {
+ ASSERT(dst != addr);
+ lbu(dst, Address(addr, 0));
+ lbu(tmp, Address(addr, 1));
+ sll(tmp, tmp, 8);
+ or_(dst, dst, tmp);
+}
+
+
+void Assembler::StoreHalfWordUnaligned(Register src,
+ Register addr,
+ Register tmp) {
+ sb(src, Address(addr, 0));
+ srl(tmp, src, 8);
+ sb(tmp, Address(addr, 1));
+}
+
+
+void Assembler::LoadWordUnaligned(Register dst, Register addr, Register tmp) {
+ // TODO(rmacnak): LWL + LWR
+ ASSERT(dst != addr);
+ lbu(dst, Address(addr, 0));
+ lbu(tmp, Address(addr, 1));
+ sll(tmp, tmp, 8);
+ or_(dst, dst, tmp);
+ lbu(tmp, Address(addr, 2));
+ sll(tmp, tmp, 16);
+ or_(dst, dst, tmp);
+ lbu(tmp, Address(addr, 3));
+ sll(tmp, tmp, 24);
+ or_(dst, dst, tmp);
+}
+
+
+void Assembler::StoreWordUnaligned(Register src, Register addr, Register tmp) {
+ // TODO(rmacnak): SWL + SWR
+ sb(src, Address(addr, 0));
+ srl(tmp, src, 8);
+ sb(tmp, Address(addr, 1));
+ srl(tmp, src, 16);
+ sb(tmp, Address(addr, 2));
+ srl(tmp, src, 24);
+ sb(tmp, Address(addr, 3));
+}
+
+
static const char* cpu_reg_names[kNumberOfCpuRegisters] = {
"zr", "tmp", "v0", "v1", "a0", "a1", "a2", "a3",
"t0", "t1", "t2", "t3", "t4", "t5", "t6", "t7",
« no previous file with comments | « runtime/vm/assembler_mips.h ('k') | runtime/vm/assembler_mips_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698