Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4089)

Unified Diff: runtime/vm/flow_graph_inliner.cc

Issue 2452453002: Support unaligned integer loads on ARM and MIPS. (Closed)
Patch Set: . Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/flow_graph_inliner.cc
diff --git a/runtime/vm/flow_graph_inliner.cc b/runtime/vm/flow_graph_inliner.cc
index 05f6579c70831abdd3c1831d916fb192056b578f..d6ca76098c3ab980ba70dcf0dea283a60838e101 100644
--- a/runtime/vm/flow_graph_inliner.cc
+++ b/runtime/vm/flow_graph_inliner.cc
@@ -2181,6 +2181,7 @@ static bool InlineGetIndexed(FlowGraph* flow_graph,
new(Z) Value(index),
index_scale,
array_cid,
+ true, // aligned
deopt_id,
call->token_pos());
cursor = flow_graph->AppendTo(
@@ -2365,6 +2366,7 @@ static bool InlineSetIndexed(FlowGraph* flow_graph,
needs_store_barrier,
index_scale,
array_cid,
+ true, // aligned
call->deopt_id(),
call->token_pos());
flow_graph->AppendTo(cursor,
@@ -2595,6 +2597,7 @@ static bool InlineByteArrayBaseLoad(FlowGraph* flow_graph,
new(Z) Value(index),
1,
view_cid,
+ false, // aligned
deopt_id,
call->token_pos());
cursor = flow_graph->AppendTo(
@@ -2766,6 +2769,7 @@ static bool InlineByteArrayBaseStore(FlowGraph* flow_graph,
needs_store_barrier,
1, // Index scale
view_cid,
+ false, // aligned
call->deopt_id(),
call->token_pos());
@@ -2834,6 +2838,7 @@ static Definition* PrepareInlineStringIndexOp(
new(Z) Value(index),
Instance::ElementSizeFor(cid),
cid,
+ true, // aligned
Thread::kNoDeoptId,
call->token_pos());
@@ -3826,6 +3831,7 @@ bool FlowGraphInliner::TryInlineRecognizedMethod(FlowGraph* flow_graph,
kNoStoreBarrier,
1, // Index scale
kOneByteStringCid,
+ true, // aligned
call->deopt_id(),
call->token_pos());
flow_graph->AppendTo(*entry,

Powered by Google App Engine
This is Rietveld 408576698