Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2452403002: [Bindings] Reformat template files (4/4) (Closed)

Created:
4 years, 1 month ago by peria
Modified:
4 years, 1 month ago
Reviewers:
haraken, bashi, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reformat template files for bindings I'm planning to change the format of templates as follows: - Interfaces (https://codereview.chromium.org/2454133002/) - Methods (https://codereview.chromium.org/2460563002/) - Attributes (https://codereview.chromium.org/2449043007/) - Others (this CL) Because reformatting them at once will be huge, especially for V8TestObject.cpp, and it can costs network if reverted. https://codereview.chromium.org/2446213002/ so I'd like to split it into few changes. BUG=660281 Committed: https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425 Cr-Commit-Position: refs/heads/master@{#428364}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4036 lines, -4394 lines) Patch
M third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl View 1 chunk +42 lines, -48 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/callback_function.h.tmpl View 1 chunk +22 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/constants.cpp.tmpl View 1 chunk +14 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/dictionary_impl.cpp.tmpl View 1 chunk +13 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/dictionary_impl.h.tmpl View 1 chunk +25 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/dictionary_v8.cpp.tmpl View 1 chunk +104 lines, -108 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/dictionary_v8.h.tmpl View 1 chunk +8 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/union_container.cpp.tmpl View 2 chunks +157 lines, -166 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/union_container.h.tmpl View 2 chunks +34 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/utilities.cpp.tmpl View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/AnyCallbackFunctionOptionalAnyArg.h View 1 chunk +22 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/AnyCallbackFunctionOptionalAnyArg.cpp View 1 chunk +32 lines, -38 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/ArrayBufferOrArrayBufferViewOrDictionary.h View 2 chunks +46 lines, -47 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/ArrayBufferOrArrayBufferViewOrDictionary.cpp View 1 chunk +79 lines, -95 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/BooleanOrStringOrUnrestrictedDouble.h View 2 chunks +46 lines, -47 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/BooleanOrStringOrUnrestrictedDouble.cpp View 1 chunk +76 lines, -92 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/DoubleOrString.h View 2 chunks +39 lines, -40 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/DoubleOrString.cpp View 1 chunk +59 lines, -72 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.h View 1 chunk +22 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.cpp View 1 chunk +34 lines, -40 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/LongOrTestDictionary.h View 2 chunks +39 lines, -40 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/LongOrTestDictionary.cpp View 1 chunk +78 lines, -91 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/NodeOrNodeList.h View 2 chunks +39 lines, -40 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/NodeOrNodeList.cpp View 1 chunk +55 lines, -68 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/StringOrArrayBufferOrArrayBufferView.h View 2 chunks +46 lines, -47 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/StringOrArrayBufferOrArrayBufferView.cpp View 1 chunk +77 lines, -93 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/StringOrDouble.h View 2 chunks +39 lines, -40 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/StringOrDouble.cpp View 1 chunk +59 lines, -72 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/StringOrStringSequence.h View 2 chunks +39 lines, -40 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/StringOrStringSequence.cpp View 1 chunk +59 lines, -72 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/StringSequenceCallbackFunctionLongSequenceArg.h View 1 chunk +22 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/StringSequenceCallbackFunctionLongSequenceArg.cpp View 1 chunk +33 lines, -39 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.h View 1 chunk +174 lines, -174 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/TestDictionary.cpp View 1 chunk +30 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/TestDictionaryDerivedImplementedAs.h View 1 chunk +26 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/TestDictionaryDerivedImplementedAs.cpp View 1 chunk +7 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/TestEnumOrDouble.h View 2 chunks +39 lines, -40 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/TestEnumOrDouble.cpp View 1 chunk +78 lines, -91 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/TestInterface2OrUint8Array.h View 2 chunks +39 lines, -40 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/TestInterface2OrUint8Array.cpp View 1 chunk +55 lines, -68 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceEventInit.h View 1 chunk +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceEventInit.cpp View 1 chunk +5 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceGarbageCollectedOrString.h View 2 chunks +39 lines, -40 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceGarbageCollectedOrString.cpp View 1 chunk +58 lines, -71 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceOrLong.h View 2 chunks +39 lines, -40 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceOrLong.cpp View 1 chunk +66 lines, -79 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceOrTestInterfaceEmpty.h View 2 chunks +39 lines, -40 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/TestInterfaceOrTestInterfaceEmpty.cpp View 1 chunk +55 lines, -68 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/TestPermissiveDictionary.h View 1 chunk +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/TestPermissiveDictionary.cpp View 1 chunk +5 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/UnrestrictedDoubleOrString.h View 2 chunks +39 lines, -40 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/UnrestrictedDoubleOrString.cpp View 1 chunk +59 lines, -72 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8SVGTestInterface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestConstants.cpp View 1 chunk +6 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.h View 1 chunk +8 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.cpp View 1 chunk +737 lines, -741 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.h View 1 chunk +8 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp View 1 chunk +115 lines, -119 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexed.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedGlobal.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedPrimaryGlobal.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp View 37 chunks +39 lines, -39 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface2.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp View 8 chunks +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp View 6 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor3.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor4.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceDocument.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInit.h View 1 chunk +8 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInit.cpp View 1 chunk +48 lines, -52 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceEventInitConstructor.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor2.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceOriginTrialEnabled.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestNode.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp View 247 chunks +266 lines, -266 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestPermissiveDictionary.h View 1 chunk +8 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp View 1 chunk +43 lines, -47 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperations.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestTypedefs.cpp View 8 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunction.h View 1 chunk +22 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunction.cpp View 1 chunk +29 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.h View 1 chunk +22 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.cpp View 1 chunk +30 lines, -36 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionTypedef.h View 1 chunk +22 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionTypedef.cpp View 1 chunk +30 lines, -36 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/BooleanOrString.h View 2 chunks +39 lines, -40 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/BooleanOrString.cpp View 1 chunk +56 lines, -69 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface2Partial.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterface5.cpp View 14 chunks +16 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp View 8 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.h View 1 chunk +22 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.cpp View 1 chunk +29 lines, -35 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
peria
PTL
4 years, 1 month ago (2016-10-27 20:23:00 UTC) #4
haraken
LGTM
4 years, 1 month ago (2016-10-27 20:30:42 UTC) #5
bashi
lgtm
4 years, 1 month ago (2016-10-27 23:51:43 UTC) #6
Yuki
lgtm
4 years, 1 month ago (2016-10-28 09:23:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2452403002/10001
4 years, 1 month ago (2016-10-28 12:39:00 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:10001)
4 years, 1 month ago (2016-10-28 14:21:54 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 14:24:53 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/250b1ec6eeeb7bdeca5d678649073eff8a02a425
Cr-Commit-Position: refs/heads/master@{#428364}

Powered by Google App Engine
This is Rietveld 408576698