|
|
Chromium Code Reviews|
Created:
4 years, 1 month ago by rnephew (Reviews Here) Modified:
4 years, 1 month ago CC:
chromium-reviews, telemetry-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Telemetry] Fix exception handling for blink_styles use of WaitFor
BUG=660042, 660046
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
Committed: https://crrev.com/b30d126f591bd1f26a4807328438abe2ddf39193
Cr-Commit-Position: refs/heads/master@{#428224}
Patch Set 1 #Patch Set 2 : Add rasterize_and_record_micro #
Messages
Total messages: 23 (13 generated)
Description was changed from ========== [Telemetry] Fix exception handling for blink_styles use of WaitFor BUG=660042 ========== to ========== [Telemetry] Fix exception handling for blink_styles use of WaitFor BUG=660042 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
rnephew@chromium.org changed reviewers: + eakuefner@chromium.org, nednguyen@google.com, zhenw@chromium.org
Description was changed from ========== [Telemetry] Fix exception handling for blink_styles use of WaitFor BUG=660042 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== [Telemetry] Fix exception handling for blink_styles use of WaitFor BUG=660042 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
Description was changed from ========== [Telemetry] Fix exception handling for blink_styles use of WaitFor BUG=660042 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== [Telemetry] Fix exception handling for blink_styles use of WaitFor BUG=660042, 660046 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
lgtm
The CQ bit was checked by rnephew@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/10/27 17:43:20, commit-bot: I haz the power wrote: > CQ is trying da patch. Follow status at > > https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... If these two fail for reasons not related to my CL, can I just remove them so that the change can land?
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_...)
Description was changed from ========== [Telemetry] Fix exception handling for blink_styles use of WaitFor BUG=660042, 660046 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== [Telemetry] Fix exception handling for blink_styles use of WaitFor BUG=660042, 660046 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
The CQ bit was checked by nednguyen@google.com
On 2016/10/27 23:44:38, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, > http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_...) Yes, I removed them.
Description was changed from ========== [Telemetry] Fix exception handling for blink_styles use of WaitFor BUG=660042, 660046 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== [Telemetry] Fix exception handling for blink_styles use of WaitFor BUG=660042, 660046 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
The CQ bit was unchecked by nednguyen@google.com
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/10/27 23:51:55, commit-bot: I haz the power wrote: > CQ is trying da patch. Follow status at > > https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or... I also think that the changes are unrelated to the failure in linux_perf_cq. That failure is being tracked in https://bugs.chromium.org/p/chromium/issues/detail?id=660048
Message was sent while issue was closed.
Description was changed from ========== [Telemetry] Fix exception handling for blink_styles use of WaitFor BUG=660042, 660046 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== [Telemetry] Fix exception handling for blink_styles use of WaitFor BUG=660042, 660046 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [Telemetry] Fix exception handling for blink_styles use of WaitFor BUG=660042, 660046 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq ========== to ========== [Telemetry] Fix exception handling for blink_styles use of WaitFor BUG=660042, 660046 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Committed: https://crrev.com/b30d126f591bd1f26a4807328438abe2ddf39193 Cr-Commit-Position: refs/heads/master@{#428224} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/b30d126f591bd1f26a4807328438abe2ddf39193 Cr-Commit-Position: refs/heads/master@{#428224} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
