Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 2452333004: [Telemetry] Fix exception handling for blink_styles and rasterize_and_record use of WaitFor (Closed)

Created:
4 years, 1 month ago by rnephew (Reviews Here)
Modified:
4 years, 1 month ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Fix exception handling for blink_styles use of WaitFor BUG=660042, 660046 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Committed: https://crrev.com/b30d126f591bd1f26a4807328438abe2ddf39193 Cr-Commit-Position: refs/heads/master@{#428224}

Patch Set 1 #

Patch Set 2 : Add rasterize_and_record_micro #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M tools/perf/measurements/blink_style.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/measurements/rasterize_and_record_micro.py View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 23 (13 generated)
rnephew (Reviews Here)
4 years, 1 month ago (2016-10-27 17:11:29 UTC) #3
nednguyen
lgtm
4 years, 1 month ago (2016-10-27 17:41:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2452333004/20001
4 years, 1 month ago (2016-10-27 17:43:20 UTC) #8
rnephew (Reviews Here)
On 2016/10/27 17:43:20, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 1 month ago (2016-10-27 23:02:59 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_s5_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_cq/builds/661)
4 years, 1 month ago (2016-10-27 23:44:38 UTC) #11
nednguyen
On 2016/10/27 23:44:38, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 1 month ago (2016-10-27 23:51:34 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2452333004/20001
4 years, 1 month ago (2016-10-27 23:51:55 UTC) #18
rnephew (Reviews Here)
On 2016/10/27 23:51:55, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 1 month ago (2016-10-27 23:56:17 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-27 23:58:39 UTC) #21
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 00:02:36 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b30d126f591bd1f26a4807328438abe2ddf39193
Cr-Commit-Position: refs/heads/master@{#428224}

Powered by Google App Engine
This is Rietveld 408576698