Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2452333003: Fix login navigation button enabling (Closed)

Created:
4 years, 1 month ago by Greg Levin
Modified:
4 years, 1 month ago
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix login navigation button enabling BUG=658014, 660011 TEST=Back, Close, and Refresh buttons should always be disabled when a modal dialog is present, and enabled otherwise. See bugs for specific repro instructions. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/652240f3d4404a949aaa0a9ca04017bd25011958 Cr-Commit-Position: refs/heads/master@{#428231}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.js View 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_gaia_signin.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Greg Levin
Please have a look!
4 years, 1 month ago (2016-10-27 15:24:20 UTC) #3
achuithb
lgtm
4 years, 1 month ago (2016-10-27 19:39:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2452333003/1
4 years, 1 month ago (2016-10-27 19:56:34 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/57254)
4 years, 1 month ago (2016-10-27 21:47:32 UTC) #8
Alexander Alekseev
lgtm
4 years, 1 month ago (2016-10-27 22:40:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2452333003/1
4 years, 1 month ago (2016-10-28 00:05:28 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 01:34:14 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 01:36:53 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/652240f3d4404a949aaa0a9ca04017bd25011958
Cr-Commit-Position: refs/heads/master@{#428231}

Powered by Google App Engine
This is Rietveld 408576698