[serializer] introduce API to serialize internal fields

[serializer] introduce API to serialize internal fields

See https://goo.gl/C9U1dL

BUG=chromium:617892
Committed: https://crrev.com/39ed137bce316138e04aefbb5165daf5ae7201ca
Cr-Commit-Position: refs/heads/master@{#40623}

[Yang, 2016-10-27 12:40:01]

yangguo@chromium.org changed reviewers:
+ haraken@chromium.org, jochen@chromium.org, peria@chromium.org

[jochen (gone - plz use gerrit), 2016-10-27 12:40:51]

lgtm with nit

https://codereview.chromium.org/2452333002/diff/1/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/2452333002/diff/1/include/v8.h#newcode6247
include/v8.h:6247: int index);
size_t ?

[haraken, 2016-10-27 12:45:32]

The V8 API LGTM

[Yang, 2016-10-27 12:49:27]

https://codereview.chromium.org/2452333002/diff/1/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/2452333002/diff/1/include/v8.h#newcode6247
include/v8.h:6247: int index);
On 2016/10/27 12:40:51, jochen wrote:
> size_t ?

v8::Object::SetInternalField uses int, so I'd like to use the same type.

[peria, 2016-10-27 12:54:31]

https://codereview.chromium.org/2452333002/diff/1/src/snapshot/partial-serial...
File src/snapshot/partial-serializer.cc (right):

https://codereview.chromium.org/2452333002/diff/1/src/snapshot/partial-serial...
src/snapshot/partial-serializer.cc:139: for (int i = 0; i <
internal_fields_count; i++) {
should we use j for the inner loop?

[Yang, 2016-10-27 13:01:56]

https://codereview.chromium.org/2452333002/diff/1/src/snapshot/partial-serial...
File src/snapshot/partial-serializer.cc (right):

https://codereview.chromium.org/2452333002/diff/1/src/snapshot/partial-serial...
src/snapshot/partial-serializer.cc:139: for (int i = 0; i <
internal_fields_count; i++) {
On 2016/10/27 12:54:31, peria wrote:
> should we use j for the inner loop?

good point.

[Yang, 2016-10-27 13:02:01]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 13:02:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[peria, 2016-10-27 13:05:38]

lgtm

[commit-bot: I haz the power, 2016-10-27 13:32:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 13:32:20]

Dry run: This issue passed the CQ dry run.

[Yang, 2016-10-27 13:33:18]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-10-27 13:33:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2452333002/#ps20001
(title: "avoid shadow variables")

[commit-bot: I haz the power, 2016-10-27 13:33:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 13:35:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-17 22:15:37]

Description was changed from

==========
[serializer] introduce API to serialize internal fields

See https://goo.gl/C9U1dL

BUG=chromium:617892
==========

to

==========
[serializer] introduce API to serialize internal fields

See https://goo.gl/C9U1dL

BUG=chromium:617892

Committed: https://crrev.com/39ed137bce316138e04aefbb5165daf5ae7201ca
Cr-Commit-Position: refs/heads/master@{#40623}
==========

[commit-bot: I haz the power, 2016-11-17 22:15:38]

Patchset 2 (id:??) landed as
https://crrev.com/39ed137bce316138e04aefbb5165daf5ae7201ca
Cr-Commit-Position: refs/heads/master@{#40623}