Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: BUILD.gn

Issue 2452313003: Creating webkit_layout_tests target. (Closed)
Patch Set: Rebase onto master Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | testing/buildbot/gn_isolate_map.pyl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 823e655cc5d1b40b00d24fea5269e3d8ce4411bf..eb1dbeb11ff710a4dec530f24e94d181cfc9ae03 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -907,16 +907,31 @@ if (!is_ios) {
testonly = true
deps = [
- "//content/shell:content_shell",
+ ":webkit_layout_tests",
"//third_party/WebKit/public:all_blink",
+ ]
+ }
+
+ # Layout tests runner
+ # third_party/WebKit/Tools/Scripts/run-webkit-tests
+ group("run_webkit_tests") {
+ testonly = true
+ deps = [
+ ":webkit_layout_tests",
+ ]
+ }
+
+ # https://www.chromium.org/developers/testing/webkit-layout-tests
+ group("webkit_layout_tests") {
+ testonly = true
+
+ data_deps = [
+ "//content/shell:content_shell",
"//tools/imagediff",
]
- # NOTE: The following deps are needed to run the layout tests
- # (run-webkit-tests) but there is no GN target for the layout tests,
- # so we need to specify the dependencies here instead.
if (is_android) {
- deps += [
+ data_deps += [
"//breakpad:breakpad_unittests",
"//breakpad:dump_syms",
"//breakpad:microdump_stackwalk",
@@ -928,24 +943,28 @@ if (!is_ios) {
}
if (is_win) {
- deps += [ "//content/shell:content_shell_crash_service" ]
+ data_deps += [ "//content/shell:content_shell_crash_service" ]
}
if (!is_win && !is_android) {
- deps += [ "//breakpad:minidump_stackwalk($host_toolchain)" ]
+ data_deps += [ "//breakpad:minidump_stackwalk($host_toolchain)" ]
}
if (is_mac) {
- deps += [ "//breakpad:dump_syms($host_toolchain)" ]
+ data_deps += [ "//breakpad:dump_syms($host_toolchain)" ]
}
if (is_linux) {
- deps += [ "//breakpad:dump_syms($host_toolchain)" ]
+ data_deps += [ "//breakpad:dump_syms($host_toolchain)" ]
}
data = [
+ "//testing/scripts/common.py",
+ "//testing/xvfb.py",
+ "//testing/scripts/run_telemetry_as_googletest.py",
"//third_party/WebKit/LayoutTests/",
"//third_party/WebKit/Tools/Scripts/",
+ "$root_build_dir/resources/inspector/",
]
}
}
« no previous file with comments | « no previous file | testing/buildbot/gn_isolate_map.pyl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698