Creating webkit_layout_tests target.

BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This is the root build file for GN. GN will start processing by loading this
 # file, and recursively load all dependencies until all dependencies are either
 # resolved or known not to exist (which will cause the build to fail). So if
 # you add a new build file, there must be some path of dependencies from this
 # file to your new one or GN won't know about it.
 
@@ skipping 881 matching lines @@
   }
 }
 
 if (!is_ios) {
   # This group includes all of the targets needed to build and test Blink,
   # including running the layout tests (see below).
   group("blink_tests") {
     testonly = true
 
     deps = [
+      ":webkit_layout_tests",
+      "//third_party/WebKit/public:all_blink",
+    ]
+  }
+
+  # Layout tests runner
+  # third_party/WebKit/Tools/Scripts/run-webkit-tests
+  group("run_webkit_tests") {
+    testonly = true
+    deps = [
+      ":webkit_layout_tests",
+    ]
+  }
+
+  # https://www.chromium.org/developers/testing/webkit-layout-tests
+  group("webkit_layout_tests") {
+    testonly = true
+
+    data_deps = [
       "//content/shell:content_shell",
-      "//third_party/WebKit/public:all_blink",
+      "//chrome/test:telemetry_gtest_wrapper",

[Dirk Pranke, 2016/11/01 16:51:00]

This should not depend on anything in //chrome. Can we move the telemetry
wrapper to a more generic place (like in //testing)?

[mithro, 2016/11/03 04:19:52]

It's unclear to me why all the telemetry targets seem to be in //chrome/test
rather than something else.

However, that is a question for the people maintaining telemetry rather than
this CL.

       "//tools/imagediff",
     ]
 
-    # NOTE: The following deps are needed to run the layout tests
-    # (run-webkit-tests) but there is no GN target for the layout tests,
-    # so we need to specify the dependencies here instead.
     if (is_android) {
-      deps += [
+      data_deps += [
         "//breakpad:breakpad_unittests",
         "//breakpad:dump_syms",
         "//breakpad:microdump_stackwalk",
         "//breakpad:minidump_dump",
         "//breakpad:minidump_stackwalk",
         "//breakpad:symupload",
         "//tools/android/forwarder2",
       ]
     }
 
     if (is_win) {
-      deps += [
+      data_deps += [
         "//components/test_runner:layout_test_helper",
         "//content/shell:content_shell_crash_service",
       ]
     }
 
     if (!is_win && !is_android) {
-      deps += [ "//breakpad:minidump_stackwalk($host_toolchain)" ]
+      data_deps += [ "//breakpad:minidump_stackwalk($host_toolchain)" ]
     }
 
     if (is_mac) {
-      deps += [ "//breakpad:dump_syms($host_toolchain)" ]
+      data_deps += [ "//breakpad:dump_syms($host_toolchain)" ]
     }
 
     if (is_linux) {
-      deps += [ "//breakpad:dump_syms($host_toolchain)" ]
+      data_deps += [ "//breakpad:dump_syms($host_toolchain)" ]
     }
 
     data = [
       "//third_party/WebKit/LayoutTests/",
       "//third_party/WebKit/Tools/Scripts/",
+      "$root_build_dir/resources/inspector/",

[Dirk Pranke, 2016/11/01 16:51:00]

This seems like it should actually be a data dependency of something in
//third_party/WebKit/Source/devtools ?

[mithro, 2016/11/03 04:19:52]

From what I can tell, these resources are actually only needed for the layout
tests which interact with the inspector. devtools/inspector itself gets the
resources via other means.

This means that it should be only a dependency for the layout tests, right?

     ]
   }
 }
 
 # Add a dummy target for compatibility w/ GYP
 group("chromium_swarm_tests") {
 }
 
 group("chromium_builder_perf") {
   testonly = true
@@ skipping 190 matching lines @@
       "//ui/display:display_unittests",
       "//ui/events:events_unittests",
       "//ui/gfx:gfx_unittests",
       "//ui/gl:gl_unittests",
       "//ui/keyboard:keyboard_unittests",
       "//ui/touch_selection:ui_touch_selection_unittests",
       "//url:url_unittests",
     ]
   }
 }