third_party/libtiff/0009-HeapBufferOverflow-PixarLogDecode.patch - Issue 2452293002: libtiff: Fix unsigned vs signed comparison warning.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/libtiff/0009-HeapBufferOverflow-PixarLogDecode.patch

Issue 2452293002: libtiff: Fix unsigned vs signed comparison warning. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/libtiff/0009-HeapBufferOverflow-PixarLogDecode.patch

diff --git a/third_party/libtiff/0009-HeapBufferOverflow-PixarLogDecode.patch b/third_party/libtiff/0009-HeapBufferOverflow-PixarLogDecode.patch

index 745da03d80e25e5ccc92b9f7cb5bb02815194743..57dbe2efb7209cfaee9721d60c8de8ac52e17b5a 100644

--- a/third_party/libtiff/0009-HeapBufferOverflow-PixarLogDecode.patch

+++ b/third_party/libtiff/0009-HeapBufferOverflow-PixarLogDecode.patch

@@ -23,7 +23,7 @@ index b93b4c7..0674fa4 100644

return (0);

}

+ /* Check that we will not fill more than what was allocated */

-+ if (sp->stream.avail_out > sp->tbuf_size)

++ if ((tmsize_t)sp->stream.avail_out > sp->tbuf_size)

+ {

+ TIFFErrorExt(tif->tif_clientdata, module, "sp->stream.avail_out > sp->tbuf_size");

+ return (0);

« no previous file with comments | « no previous file | third_party/libtiff/tif_pixarlog.c » ('j') | no next file with comments »