Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: chrome/browser/chromeos/net/network_connect_delegate_chromeos.cc

Issue 2452283003: chromeos: Make network enrollment and SIM unlock dialogs work with mash (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/net/network_connect_delegate_chromeos.cc
diff --git a/chrome/browser/chromeos/net/network_connect_delegate_chromeos.cc b/chrome/browser/chromeos/net/network_connect_delegate_chromeos.cc
index 895a4b16855923c24ab09aa81063c8c0a5c1d5cb..614c505baf90abd477d6c07b31665c8f492482e8 100644
--- a/chrome/browser/chromeos/net/network_connect_delegate_chromeos.cc
+++ b/chrome/browser/chromeos/net/network_connect_delegate_chromeos.cc
@@ -4,32 +4,24 @@
#include "chrome/browser/chromeos/net/network_connect_delegate_chromeos.h"
-#include "ash/common/session/session_state_delegate.h"
-#include "ash/common/wm_shell.h"
-#include "ash/shell.h"
#include "chrome/browser/chromeos/enrollment_dialog_view.h"
+#include "chrome/browser/chromeos/login/lock/screen_locker.h"
#include "chrome/browser/chromeos/net/network_state_notifier.h"
#include "chrome/browser/chromeos/sim_dialog_delegate.h"
#include "chrome/browser/ui/ash/system_tray_client.h"
#include "chrome/browser/ui/webui/chromeos/mobile_setup_dialog.h"
+namespace chromeos {
stevenjb 2016/10/27 18:45:13 nit: blank line
James Cook 2016/10/27 22:28:27 Done.
namespace {
bool IsUIAvailable() {
- return ash::WmShell::HasInstance() &&
- !ash::WmShell::Get()->GetSessionStateDelegate()->IsScreenLocked();
-}
-
-gfx::NativeWindow GetNativeWindow() {
- int container_id = SystemTrayClient::GetDialogParentContainerId();
- return ash::Shell::GetContainer(ash::Shell::GetPrimaryRootWindow(),
- container_id);
+ // UI is available when screen is unlocked.
+ return !ScreenLocker::default_screen_locker() ||
+ !ScreenLocker::default_screen_locker()->locked();
}
} // namespace
-namespace chromeos {
-
NetworkConnectDelegateChromeOS::NetworkConnectDelegateChromeOS()
: network_state_notifier_(new NetworkStateNotifier()) {}
@@ -53,13 +45,13 @@ bool NetworkConnectDelegateChromeOS::ShowEnrollNetwork(
const std::string& network_id) {
if (!IsUIAvailable())
return false;
- return enrollment::CreateDialog(network_id, GetNativeWindow());
+ return enrollment::CreateDialog(network_id, nullptr /* owning_window */);
}
void NetworkConnectDelegateChromeOS::ShowMobileSimDialog() {
if (!IsUIAvailable())
return;
- SimDialogDelegate::ShowDialog(GetNativeWindow(),
+ SimDialogDelegate::ShowDialog(nullptr /* owning_window */,
SimDialogDelegate::SIM_DIALOG_UNLOCK);
}

Powered by Google App Engine
This is Rietveld 408576698