Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Side by Side Diff: chrome/browser/ui/ash/system_tray_client.cc

Issue 2452283003: chromeos: Make network enrollment and SIM unlock dialogs work with mash (Closed)
Patch Set: review comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/ash/system_tray_client.h" 5 #include "chrome/browser/ui/ash/system_tray_client.h"
6 6
7 #include "ash/common/login_status.h" 7 #include "ash/common/login_status.h"
8 #include "ash/common/session/session_state_delegate.h" 8 #include "ash/common/session/session_state_delegate.h"
9 #include "ash/common/wm_shell.h" 9 #include "ash/common/wm_shell.h"
10 #include "ash/public/cpp/shell_window_ids.h" 10 #include "ash/public/cpp/shell_window_ids.h"
11 #include "ash/shell.h"
11 #include "base/bind.h" 12 #include "base/bind.h"
12 #include "base/bind_helpers.h" 13 #include "base/bind_helpers.h"
13 #include "base/logging.h" 14 #include "base/logging.h"
14 #include "chrome/browser/browser_process.h" 15 #include "chrome/browser/browser_process.h"
15 #include "chrome/browser/browser_process_platform_part.h" 16 #include "chrome/browser/browser_process_platform_part.h"
16 #include "chrome/browser/chromeos/accessibility/accessibility_util.h" 17 #include "chrome/browser/chromeos/accessibility/accessibility_util.h"
17 #include "chrome/browser/chromeos/login/ui/login_display_host.h" 18 #include "chrome/browser/chromeos/login/ui/login_display_host.h"
18 #include "chrome/browser/chromeos/options/network_config_view.h" 19 #include "chrome/browser/chromeos/options/network_config_view.h"
19 #include "chrome/browser/chromeos/set_time_dialog.h" 20 #include "chrome/browser/chromeos/set_time_dialog.h"
20 #include "chrome/browser/chromeos/system/system_clock.h" 21 #include "chrome/browser/chromeos/system/system_clock.h"
21 #include "chrome/browser/chromeos/ui/choose_mobile_network_dialog.h" 22 #include "chrome/browser/chromeos/ui/choose_mobile_network_dialog.h"
22 #include "chrome/browser/profiles/profile_manager.h" 23 #include "chrome/browser/profiles/profile_manager.h"
23 #include "chrome/browser/ui/ash/ash_util.h" 24 #include "chrome/browser/ui/ash/ash_util.h"
24 #include "chrome/browser/ui/chrome_pages.h" 25 #include "chrome/browser/ui/chrome_pages.h"
25 #include "chrome/browser/ui/scoped_tabbed_browser_displayer.h" 26 #include "chrome/browser/ui/scoped_tabbed_browser_displayer.h"
26 #include "chrome/browser/ui/singleton_tabs.h" 27 #include "chrome/browser/ui/singleton_tabs.h"
27 #include "chrome/common/url_constants.h" 28 #include "chrome/common/url_constants.h"
28 #include "chrome/grit/generated_resources.h" 29 #include "chrome/grit/generated_resources.h"
29 #include "chromeos/dbus/dbus_thread_manager.h" 30 #include "chromeos/dbus/dbus_thread_manager.h"
30 #include "chromeos/dbus/session_manager_client.h" 31 #include "chromeos/dbus/session_manager_client.h"
31 #include "chromeos/login/login_state.h" 32 #include "chromeos/login/login_state.h"
32 #include "content/public/browser/user_metrics.h" 33 #include "content/public/browser/user_metrics.h"
33 #include "content/public/common/service_manager_connection.h" 34 #include "content/public/common/service_manager_connection.h"
34 #include "net/base/escape.h" 35 #include "net/base/escape.h"
35 #include "services/service_manager/public/cpp/connector.h" 36 #include "services/service_manager/public/cpp/connector.h"
37 #include "services/ui/public/cpp/property_type_converters.h"
38 #include "services/ui/public/interfaces/window_manager.mojom.h"
36 #include "third_party/cros_system_api/dbus/shill/dbus-constants.h" 39 #include "third_party/cros_system_api/dbus/shill/dbus-constants.h"
37 #include "ui/base/l10n/l10n_util.h" 40 #include "ui/base/l10n/l10n_util.h"
41 #include "ui/views/widget/widget.h"
42 #include "ui/views/window/dialog_delegate.h"
38 43
39 using chromeos::DBusThreadManager; 44 using chromeos::DBusThreadManager;
40 using chromeos::LoginState; 45 using chromeos::LoginState;
46 using views::Widget;
41 47
42 namespace { 48 namespace {
43 49
44 const char kDisplaySettingsSubPageName[] = "display"; 50 const char kDisplaySettingsSubPageName[] = "display";
45 const char kPaletteSettingsSubPageName[] = "stylus-overlay"; 51 const char kPaletteSettingsSubPageName[] = "stylus-overlay";
46 52
47 SystemTrayClient* g_instance = nullptr; 53 SystemTrayClient* g_instance = nullptr;
48 54
49 void ShowSettingsSubPageForActiveUser(const std::string& sub_page) { 55 void ShowSettingsSubPageForActiveUser(const std::string& sub_page) {
50 chrome::ShowSettingsSubPageForProfile(ProfileManager::GetActiveUserProfile(), 56 chrome::ShowSettingsSubPageForProfile(ProfileManager::GetActiveUserProfile(),
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
124 wm_shell->GetSessionStateDelegate()->IsActiveUserSessionStarted(); 130 wm_shell->GetSessionStateDelegate()->IsActiveUserSessionStarted();
125 const bool is_in_secondary_login_screen = 131 const bool is_in_secondary_login_screen =
126 wm_shell->GetSessionStateDelegate()->IsInSecondaryLoginScreen(); 132 wm_shell->GetSessionStateDelegate()->IsInSecondaryLoginScreen();
127 133
128 if (!session_started || is_in_secondary_login_screen) 134 if (!session_started || is_in_secondary_login_screen)
129 return ash::kShellWindowId_LockSystemModalContainer; 135 return ash::kShellWindowId_LockSystemModalContainer;
130 136
131 return ash::kShellWindowId_SystemModalContainer; 137 return ash::kShellWindowId_SystemModalContainer;
132 } 138 }
133 139
140 // static
141 Widget* SystemTrayClient::CreateUnownedDialogWidget(
142 views::WidgetDelegate* widget_delegate) {
143 DCHECK(widget_delegate);
144 Widget::InitParams params = views::DialogDelegate::GetDialogWidgetInitParams(
145 widget_delegate, nullptr, nullptr, gfx::Rect());
146 // Place the dialog in the appropriate modal dialog container, either above
147 // or below the lock screen, based on the login state.
148 int container_id = GetDialogParentContainerId();
149 if (chrome::IsRunningInMash()) {
150 using ui::mojom::WindowManager;
151 params.mus_properties[WindowManager::kInitialContainerId_Property] =
152 mojo::ConvertTo<std::vector<uint8_t>>(container_id);
153 } else {
154 params.parent = ash::Shell::GetContainer(ash::Shell::GetPrimaryRootWindow(),
155 container_id);
156 }
157 Widget* widget = new Widget; // Owned by native widget.
158 widget->Init(params);
159 return widget;
160 }
161
134 //////////////////////////////////////////////////////////////////////////////// 162 ////////////////////////////////////////////////////////////////////////////////
135 // ash::mojom::SystemTrayClient: 163 // ash::mojom::SystemTrayClient:
136 164
137 void SystemTrayClient::ShowSettings() { 165 void SystemTrayClient::ShowSettings() {
138 ShowSettingsSubPageForActiveUser(std::string()); 166 ShowSettingsSubPageForActiveUser(std::string());
139 } 167 }
140 168
141 void SystemTrayClient::ShowDateSettings() { 169 void SystemTrayClient::ShowDateSettings() {
142 content::RecordAction(base::UserMetricsAction("ShowDateOptions")); 170 content::RecordAction(base::UserMetricsAction("ShowDateOptions"));
143 std::string sub_page = 171 std::string sub_page =
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
280 connector->ConnectToInterface("service:content_browser", &system_tray_); 308 connector->ConnectToInterface("service:content_browser", &system_tray_);
281 309
282 // Tolerate ash crashing and coming back up. 310 // Tolerate ash crashing and coming back up.
283 system_tray_.set_connection_error_handler(base::Bind( 311 system_tray_.set_connection_error_handler(base::Bind(
284 &SystemTrayClient::OnClientConnectionError, base::Unretained(this))); 312 &SystemTrayClient::OnClientConnectionError, base::Unretained(this)));
285 } 313 }
286 314
287 void SystemTrayClient::OnClientConnectionError() { 315 void SystemTrayClient::OnClientConnectionError() {
288 system_tray_.reset(); 316 system_tray_.reset();
289 } 317 }
OLDNEW
« chrome/browser/ui/ash/system_tray_client.h ('K') | « chrome/browser/ui/ash/system_tray_client.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698