Issue 2452233002: Move validity checks from WebappInfo#create() to WebappInfo() constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2452233002: Move validity checks from WebappInfo#create() to WebappInfo() constructor (Closed)

Created:
4 years, 1 month ago by pkotwicz

Modified:
4 years, 1 month ago

Reviewers:
dominickn

CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org, agrieve+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Move validity checks from WebappInfo#create() to WebappInfo() constructor BUG=659845

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -9 lines)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappInfo.java	View	1	5 chunks	+11 lines, -9 lines	0 comments	Download

Total messages: 6 (4 generated)

pkotwicz

4 years, 1 month ago (2016-10-27 15:23:15 UTC) #5

Abandoning this CL per offline discussion. I will duplicate the validity
checking logic in WebappInfo#create() and WebApkInfo#create()