It2Me Host changes to better support Confirmation Dialog

remoting/host/it2me/it2me_host.h

Index: remoting/host/it2me/it2me_host.h
diff --git a/remoting/host/it2me/it2me_host.h b/remoting/host/it2me/it2me_host.h
index 08a2bcedb71bed085e9d473c8a3ac49a1c08cf40..f2e8565ab09e5de6b85b4ff4e424f18b88676437 100644
--- a/remoting/host/it2me/it2me_host.h
+++ b/remoting/host/it2me/it2me_host.h
@@ -37,8 +37,8 @@ class PolicyWatcher;
 class RegisterSupportHostRequest;
 class RsaKeyPair;
 
-// These state values are duplicated in host_session.js and the Android Java
-// It2MeObserver class. Remember to update all copies when making changes.
+// These state values are duplicated in host_session.js.  Remember to update
+// both copies when making changes.
 enum It2MeHostState {
   kDisconnected,
   kStarting,
@@ -46,7 +46,8 @@ enum It2MeHostState {
   kReceivedAccessCode,
   kConnected,
   kError,
-  kInvalidDomainError
+  kInvalidDomainError,
+  kConnecting,

[Sergey Ulanov, 2016/10/27 22:44:12]

I don't think there is any reason to keep the current order, so maybe move this
above to keep states in their logical order.
 

[joedow, 2016/10/31 17:16:07]

I wanted to make sure that mismatched host/clients (i.e. new host w/ old client
or vice versa) would use the same mapping.  Leaving this as-is means that an
older client will just log 'unknown' event for the kConnecting state instead of
interpreting it as something else.

[Sergey Ulanov, 2016/10/31 18:21:17]

The state is sent from host to client as a string, i.e. as "CONNECTING", so
order of the states and their int values shouldn't matter - the webapp should
still handle it correctly.

(BTW it logs int value of the state here:
https://codesearch.chromium.org/chromium/src/remoting/webapp/crd/js/host_scre...,
but this doesn't seem useful because it's always converted to -1 at that point.
Correct value is logged here:
https://codesearch.chromium.org/chromium/src/remoting/webapp/crd/js/host_sess...)

[joedow, 2016/10/31 18:58:39]

Ah, I didn't expect that we were using a stringified version of the values. 
I've reordered them to match the connection sequence.

 };
 
 // Internal implementation of the plugin's It2Me host function.