It2Me Host changes to better support Confirmation Dialog

remoting/host/it2me/it2me_host.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_HOST_IT2ME_IT2ME_HOST_H_
 #define REMOTING_HOST_IT2ME_IT2ME_HOST_H_
 
 #include <memory>
 #include <string>
 
@@ skipping 19 matching lines @@
 class ChromotingHost;
 class ChromotingHostContext;
 class DesktopEnvironmentFactory;
 class HostEventLogger;
 class HostNPScriptObject;
 class HostStatusLogger;
 class PolicyWatcher;
 class RegisterSupportHostRequest;
 class RsaKeyPair;
 
-// These state values are duplicated in host_session.js and the Android Java
-// It2MeObserver class. Remember to update all copies when making changes.
+// These state values are duplicated in host_session.js.  Remember to update
+// both copies when making changes.
 enum It2MeHostState {
   kDisconnected,
   kStarting,
   kRequestedAccessCode,
   kReceivedAccessCode,
   kConnected,
   kError,
-  kInvalidDomainError
+  kInvalidDomainError,
+  kConnecting,

[Sergey Ulanov, 2016/10/27 22:44:12]

I don't think there is any reason to keep the current order, so maybe move this
above to keep states in their logical order.
 

[joedow, 2016/10/31 17:16:07]

I wanted to make sure that mismatched host/clients (i.e. new host w/ old client
or vice versa) would use the same mapping.  Leaving this as-is means that an
older client will just log 'unknown' event for the kConnecting state instead of
interpreting it as something else.

[Sergey Ulanov, 2016/10/31 18:21:17]

The state is sent from host to client as a string, i.e. as "CONNECTING", so
order of the states and their int values shouldn't matter - the webapp should
still handle it correctly.

(BTW it logs int value of the state here:
https://codesearch.chromium.org/chromium/src/remoting/webapp/crd/js/host_scre...,
but this doesn't seem useful because it's always converted to -1 at that point.
Correct value is logged here:
https://codesearch.chromium.org/chromium/src/remoting/webapp/crd/js/host_sess...)

[joedow, 2016/10/31 18:58:39]

Ah, I didn't expect that we were using a stringified version of the values. 
I've reordered them to match the connection sequence.

 };
 
 // Internal implementation of the plugin's It2Me host function.
 class It2MeHost : public base::RefCountedThreadSafe<It2MeHost>,
                   public HostStatusObserver {
  public:
   class Observer {
    public:
     virtual void OnClientAuthenticated(const std::string& client_username) = 0;
     virtual void OnStoreAccessCode(const std::string& access_code,
@@ skipping 160 matching lines @@
       const std::string& username,
       const std::string& directory_bot_jid);
 
  private:
   DISALLOW_COPY_AND_ASSIGN(It2MeHostFactory);
 };
 
 }  // namespace remoting
 
 #endif  // REMOTING_HOST_IT2ME_IT2ME_HOST_H_