Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2452193003: [crankshaft] Support all oddballs for truncating TaggedToI changes. (Closed)

Created:
4 years, 1 month ago by Benedikt Meurer
Modified:
4 years, 1 month ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com, mythria, rmcilroy, Leszek Swirski
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Support all oddballs for truncating TaggedToI changes. For inputs to truncating binary operations like <<, | or >>>, support all Oddballs not just undefined, true and false. This unifies treatment of these truncations in Crankshaft and TurboFan, and is very easy nowadays, since the memory layout of Oddball and HeapNumber is compatible. R=yangguo@chromium.org BUG=v8:5400 Committed: https://crrev.com/7d383be9da728997e0c0a68500a6ac2f248240c1 Cr-Commit-Position: refs/heads/master@{#40608}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+269 lines, -226 lines) Patch
M src/compiler/common-operator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/effect-control-linearizer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/crankshaft/arm/lithium-codegen-arm.cc View 1 chunk +5 lines, -27 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 chunk +10 lines, -22 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 chunk +9 lines, -25 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 chunk +6 lines, -28 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 chunk +6 lines, -28 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 1 chunk +10 lines, -27 lines 0 comments Download
M src/deoptimize-reason.h View 1 chunk +64 lines, -64 lines 0 comments Download
M src/ic/ic-state.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A test/mjsunit/compiler/deopt-numberoroddball-binop.js View 1 chunk +155 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Benedikt Meurer
4 years, 1 month ago (2016-10-27 05:23:40 UTC) #1
Benedikt Meurer
Hey Yang, Another Crankshaft unification change for type feedback in binary operations; essentially porting behavior ...
4 years, 1 month ago (2016-10-27 05:24:58 UTC) #4
Yang
On 2016/10/27 05:24:58, Benedikt Meurer wrote: > Hey Yang, > > Another Crankshaft unification change ...
4 years, 1 month ago (2016-10-27 05:26:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2452193003/1
4 years, 1 month ago (2016-10-27 05:37:43 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 05:59:52 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:14:55 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7d383be9da728997e0c0a68500a6ac2f248240c1
Cr-Commit-Position: refs/heads/master@{#40608}

Powered by Google App Engine
This is Rietveld 408576698