Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Side by Side Diff: media/base/audio_renderer_mixer_input.cc

Issue 2452183003: Revert of Make more media APIs aware of |delay| and |delay_timestamp| (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/base/audio_renderer_mixer.cc ('k') | media/base/audio_renderer_mixer_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/base/audio_renderer_mixer_input.h" 5 #include "media/base/audio_renderer_mixer_input.h"
6 6
7 #include <cmath> 7 #include <cmath>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/callback_helpers.h" 10 #include "base/callback_helpers.h"
11 #include "base/trace_event/trace_event.h" 11 #include "base/trace_event/trace_event.h"
12 #include "media/base/audio_renderer_mixer.h" 12 #include "media/base/audio_renderer_mixer.h"
13 #include "media/base/audio_renderer_mixer_pool.h" 13 #include "media/base/audio_renderer_mixer_pool.h"
14 #include "media/base/audio_timestamp_helper.h"
15 14
16 namespace media { 15 namespace media {
17 16
18 AudioRendererMixerInput::AudioRendererMixerInput( 17 AudioRendererMixerInput::AudioRendererMixerInput(
19 AudioRendererMixerPool* mixer_pool, 18 AudioRendererMixerPool* mixer_pool,
20 int owner_id, 19 int owner_id,
21 const std::string& device_id, 20 const std::string& device_id,
22 const url::Origin& security_origin, 21 const url::Origin& security_origin,
23 AudioLatency::LatencyType latency) 22 AudioLatency::LatencyType latency)
24 : mixer_pool_(mixer_pool), 23 : mixer_pool_(mixer_pool),
(...skipping 137 matching lines...) Expand 10 before | Expand all | Expand 10 after
162 device_id_ = device_id; 161 device_id_ = device_id;
163 security_origin_ = security_origin; 162 security_origin_ = security_origin;
164 } 163 }
165 164
166 callback.Run(OUTPUT_DEVICE_STATUS_OK); 165 callback.Run(OUTPUT_DEVICE_STATUS_OK);
167 } 166 }
168 167
169 double AudioRendererMixerInput::ProvideInput(AudioBus* audio_bus, 168 double AudioRendererMixerInput::ProvideInput(AudioBus* audio_bus,
170 uint32_t frames_delayed) { 169 uint32_t frames_delayed) {
171 TRACE_EVENT0("audio", "AudioRendererMixerInput::ProvideInput"); 170 TRACE_EVENT0("audio", "AudioRendererMixerInput::ProvideInput");
172 const base::TimeDelta delay = 171 int frames_filled = callback_->Render(audio_bus, frames_delayed, 0);
173 AudioTimestampHelper::FramesToTime(frames_delayed, params_.sample_rate());
174
175 int frames_filled =
176 callback_->Render(delay, base::TimeTicks::Now(), 0, audio_bus);
177 172
178 // AudioConverter expects unfilled frames to be zeroed. 173 // AudioConverter expects unfilled frames to be zeroed.
179 if (frames_filled < audio_bus->frames()) { 174 if (frames_filled < audio_bus->frames()) {
180 audio_bus->ZeroFramesPartial( 175 audio_bus->ZeroFramesPartial(
181 frames_filled, audio_bus->frames() - frames_filled); 176 frames_filled, audio_bus->frames() - frames_filled);
182 } 177 }
183 178
184 // We're reading |volume_| from the audio device thread and must avoid racing 179 // We're reading |volume_| from the audio device thread and must avoid racing
185 // with the main/media thread calls to SetVolume(). See thread safety comment 180 // with the main/media thread calls to SetVolume(). See thread safety comment
186 // in the header file. 181 // in the header file.
187 { 182 {
188 base::AutoLock auto_lock(volume_lock_); 183 base::AutoLock auto_lock(volume_lock_);
189 return frames_filled > 0 ? volume_ : 0; 184 return frames_filled > 0 ? volume_ : 0;
190 } 185 }
191 } 186 }
192 187
193 void AudioRendererMixerInput::OnRenderError() { 188 void AudioRendererMixerInput::OnRenderError() {
194 callback_->OnRenderError(); 189 callback_->OnRenderError();
195 } 190 }
196 191
197 } // namespace media 192 } // namespace media
OLDNEW
« no previous file with comments | « media/base/audio_renderer_mixer.cc ('k') | media/base/audio_renderer_mixer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698