Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(800)

Issue 2452163003: headless: Remove usage of worker domain (Closed)

Created:
4 years, 1 month ago by Sami
Modified:
4 years, 1 month ago
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

headless: Remove usage of worker domain The worker domain is no longer there in DevTools so let's not try to export it in headless anymore. BUG=546953 Committed: https://crrev.com/587e4b889a55afab010d248e1fe34048d8d21d78 Cr-Commit-Position: refs/heads/master@{#428022}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M headless/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M headless/lib/browser/headless_devtools_client_impl.h View 3 chunks +0 lines, -3 lines 0 comments Download
M headless/lib/browser/headless_devtools_client_impl.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M headless/public/headless_devtools_client.h View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Sami
4 years, 1 month ago (2016-10-27 13:24:37 UTC) #3
alex clarke (OOO till 29th)
lgtm
4 years, 1 month ago (2016-10-27 13:28:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2452163003/1
4 years, 1 month ago (2016-10-27 13:33:54 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 14:44:42 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 14:47:54 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/587e4b889a55afab010d248e1fe34048d8d21d78
Cr-Commit-Position: refs/heads/master@{#428022}

Powered by Google App Engine
This is Rietveld 408576698