Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Issue 2452153002: Break svg/parser tests into pieces to avoid timeouts (Closed)

Created:
4 years, 1 month ago by Stephen Chennney
Modified:
4 years, 1 month ago
Reviewers:
fs
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Break svg/parser tests into pieces to avoid timeouts Test svg/parser/whitespace-angle.html has been broken into 2 around valid values. Note this means we run one set of tests twice, once in each piece for invalid.forEach(validunits.forEach(... Tests svg/parser/whitespace-length-invalid-1.html and svg/parser/whitespace-length-invalid-2.html have been re-arranged into 4 pieces around the set of invalid values. R=fs@opera.com BUG=630967 Committed: https://crrev.com/64a07f9de4134dc11c7b9ca2fb30b32cc9ef83cf Cr-Commit-Position: refs/heads/master@{#428010}

Patch Set 1 #

Patch Set 2 : New baselines. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5016 lines, -10545 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/parser/whitespace-angle.html View 1 chunk +0 lines, -34 lines 0 comments Download
A + third_party/WebKit/LayoutTests/svg/parser/whitespace-angle-1.html View 1 chunk +3 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/svg/parser/whitespace-angle-1-expected.txt View 1 35 chunks +0 lines, -492 lines 0 comments Download
A + third_party/WebKit/LayoutTests/svg/parser/whitespace-angle-2.html View 1 chunk +3 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/svg/parser/whitespace-angle-2-expected.txt View 1 30 chunks +0 lines, -656 lines 0 comments Download
D third_party/WebKit/LayoutTests/svg/parser/whitespace-angle-expected.txt View 1 chunk +0 lines, -4351 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/parser/whitespace-length-invalid-1.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/svg/parser/whitespace-length-invalid-1-expected.txt View 1 50 chunks +0 lines, -1000 lines 0 comments Download
M third_party/WebKit/LayoutTests/svg/parser/whitespace-length-invalid-2.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/svg/parser/whitespace-length-invalid-2-expected.txt View 1 51 chunks +1000 lines, -4000 lines 0 comments Download
A + third_party/WebKit/LayoutTests/svg/parser/whitespace-length-invalid-3.html View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/svg/parser/whitespace-length-invalid-3-expected.txt View 1 1 chunk +2003 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/svg/parser/whitespace-length-invalid-4.html View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/svg/parser/whitespace-length-invalid-4-expected.txt View 1 1 chunk +2003 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Stephen Chennney
In the interests of reducing TestExpectations lines, it seems simple enough to break these tests ...
4 years, 1 month ago (2016-10-26 17:58:46 UTC) #1
fs
On 2016/10/26 at 17:58:46, schenney wrote: > In the interests of reducing TestExpectations lines, it ...
4 years, 1 month ago (2016-10-27 09:14:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2452153002/20001
4 years, 1 month ago (2016-10-27 13:10:39 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-27 13:16:30 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 13:19:02 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/64a07f9de4134dc11c7b9ca2fb30b32cc9ef83cf
Cr-Commit-Position: refs/heads/master@{#428010}

Powered by Google App Engine
This is Rietveld 408576698