Upload an image that demonstrates issue 5883

Upload an image that demonstrates issue 5883

This GIF is missing a color table. We should draw a blank frame. This
was fixed in crrev.com/2450943002 (DIFFERENT ISSUE). This image will
test this case.

BUG=skia:5883
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2452133003

Committed: https://skia.googlesource.com/skia/+/2111633dc63a5b7c629b4cc33f7c67d27e1246e6

[scroggo_chromium, 2016-10-26 20:17:17]

Description was changed from

==========
Upload an image that demonstrates issue 5883

This GIF is missing a color table. We should draw a blank frame. This
was fixed in crrev.com/2450943002 (DIFFERENT ISSUE). This image will
test this case.

BUG=skia:5883
==========

to

==========
Upload an image that demonstrates issue 5883

This GIF is missing a color table. We should draw a blank frame. This
was fixed in crrev.com/2450943002 (DIFFERENT ISSUE). This image will
test this case.

BUG=skia:5883
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2452133003
==========

[scroggo_chromium, 2016-10-26 20:17:32]

scroggo@chromium.org changed reviewers:
+ msarett@google.com

[scroggo_chromium, 2016-10-26 20:22:33]

scroggo@chromium.org changed reviewers:
+ borenet@google.com

[scroggo_chromium, 2016-10-26 20:22:34]

borenet@, I used the infra/bots/assets/skimage/create_and_upload.py script you
recommended, but when I run

  git cl upload

I get the following error:

"""
Running presubmit upload checks ...
Test failures:

==============================
Failed to run gen_tests.go:

gen_tasks.go:22:2: cannot find package
"go.skia.org/infra/task_scheduler/go/specs" in any of:
	/usr/lib/google-golang/src/go.skia.org/infra/task_scheduler/go/specs (from
$GOROOT)
	/usr/local/google/GO/src/go.skia.org/infra/task_scheduler/go/specs (from
$GOPATH)

Maybe you need to run:

$ go get -u go.skia.org/infra/...
==============================

** Presubmit ERRORS **
`python infra/bots/infra_tests.py` failed:

"""
Running the suggested command fails, but I was able to upload with
--bypass-hooks. Should I be worried? What do I need to do to fix this?

[msarett, 2016-10-26 20:47:00]

lgtm

[scroggo_chromium, 2016-10-27 20:07:16]

Eric, thanks for helping me with the presubmit issues. I'm still getting the
following message though:

Test failures:

==============================
E1027 16:05:17.209133   32432 common.go:37] Initializing logserver for log level
ERROR.
F1027 16:05:17.306698   32432 helpers.go:204] Expected no changes, but changes
were found!
goroutine 1 [running]:
github.com/skia-dev/glog.stacks(0xab0900, 0xc400000000, 0x5b, 0x9e)
	/usr/local/google/GO/src/github.com/skia-dev/glog/glog.go:769 +0xa5
github.com/skia-dev/glog.(*loggingT).output(0xa93b00, 0xc400000003,
0xc4201f8180, 0xa65154, 0xa, 0xcc, 0x0)
	/usr/local/google/GO/src/github.com/skia-dev/glog/glog.go:720 +0x337
github.com/skia-dev/glog.(*loggingT).printDepth(0xa93b00, 0x3, 0x1,
0xc4201a5e48, 0x1, 0x1)
	/usr/local/google/GO/src/github.com/skia-dev/glog/glog.go:649 +0x126
github.com/skia-dev/glog.(*loggingT).print(0xa93b00, 0xc400000003, 0xc4201a5e48,
0x1, 0x1)
	/usr/local/google/GO/src/github.com/skia-dev/glog/glog.go:640 +0x5a
github.com/skia-dev/glog.Fatal(0xc4201a5e48, 0x1, 0x1)
	/usr/local/google/GO/src/github.com/skia-dev/glog/glog.go:1128 +0x53
go.skia.org/infra/task_scheduler/go/specs.(*TasksCfgBuilder).MustFinish(0xc4201ed3e0)
	/usr/local/google/GO/src/go.skia.org/infra/task_scheduler/go/specs/helpers.go:204
+0x9c
main.main()
	/usr/local/google/skia/infra/bots/gen_tasks.go:514 +0x157
exit status 255

==============================

** Presubmit ERRORS **
`python infra/bots/infra_tests.py` failed:

[borenet, 2016-10-27 20:09:32]

On 2016/10/27 20:07:16, scroggo_chromium wrote:
> Eric, thanks for helping me with the presubmit issues. I'm still getting the
> following message though:
> 
> Test failures:
> 
> ==============================
> E1027 16:05:17.209133   32432 common.go:37] Initializing logserver for log
level
> ERROR.
> F1027 16:05:17.306698   32432 helpers.go:204] Expected no changes, but changes
> were found!
> goroutine 1 [running]:
> github.com/skia-dev/glog.stacks(0xab0900, 0xc400000000, 0x5b, 0x9e)
> 	/usr/local/google/GO/src/github.com/skia-dev/glog/glog.go:769 +0xa5
> github.com/skia-dev/glog.(*loggingT).output(0xa93b00, 0xc400000003,
> 0xc4201f8180, 0xa65154, 0xa, 0xcc, 0x0)
> 	/usr/local/google/GO/src/github.com/skia-dev/glog/glog.go:720 +0x337
> github.com/skia-dev/glog.(*loggingT).printDepth(0xa93b00, 0x3, 0x1,
> 0xc4201a5e48, 0x1, 0x1)
> 	/usr/local/google/GO/src/github.com/skia-dev/glog/glog.go:649 +0x126
> github.com/skia-dev/glog.(*loggingT).print(0xa93b00, 0xc400000003,
0xc4201a5e48,
> 0x1, 0x1)
> 	/usr/local/google/GO/src/github.com/skia-dev/glog/glog.go:640 +0x5a
> github.com/skia-dev/glog.Fatal(0xc4201a5e48, 0x1, 0x1)
> 	/usr/local/google/GO/src/github.com/skia-dev/glog/glog.go:1128 +0x53
>
go.skia.org/infra/task_scheduler/go/specs.(*TasksCfgBuilder).MustFinish(0xc4201ed3e0)
>
	/usr/local/google/GO/src/go.skia.org/infra/task_scheduler/go/specs/helpers.go:204
> +0x9c
> main.main()
> 	/usr/local/google/skia/infra/bots/gen_tasks.go:514 +0x157
> exit status 255
> 
> ==============================
> 
> ** Presubmit ERRORS **
> `python infra/bots/infra_tests.py` failed:

You'll need to run:
$ go run ./infra/bots/gen_tasks.go

That regenerates the tasks.json file which needs to be done whenever an asset
version changes.  That file defines the bots and swarming tasks used in the new
buildbotless world.

[scroggo_chromium, 2016-10-27 20:56:40]

On 2016/10/27 20:09:32, borenet wrote:
> On 2016/10/27 20:07:16, scroggo_chromium wrote:
> > Eric, thanks for helping me with the presubmit issues. I'm still getting the
> > following message though:
> > 
> > Test failures:
> > 
> > ==============================
> > E1027 16:05:17.209133   32432 common.go:37] Initializing logserver for log
> level
> > ERROR.
> > F1027 16:05:17.306698   32432 helpers.go:204] Expected no changes, but
changes
> > were found!
> > goroutine 1 [running]:
> > github.com/skia-dev/glog.stacks(0xab0900, 0xc400000000, 0x5b, 0x9e)
> > 	/usr/local/google/GO/src/github.com/skia-dev/glog/glog.go:769 +0xa5
> > github.com/skia-dev/glog.(*loggingT).output(0xa93b00, 0xc400000003,
> > 0xc4201f8180, 0xa65154, 0xa, 0xcc, 0x0)
> > 	/usr/local/google/GO/src/github.com/skia-dev/glog/glog.go:720 +0x337
> > github.com/skia-dev/glog.(*loggingT).printDepth(0xa93b00, 0x3, 0x1,
> > 0xc4201a5e48, 0x1, 0x1)
> > 	/usr/local/google/GO/src/github.com/skia-dev/glog/glog.go:649 +0x126
> > github.com/skia-dev/glog.(*loggingT).print(0xa93b00, 0xc400000003,
> 0xc4201a5e48,
> > 0x1, 0x1)
> > 	/usr/local/google/GO/src/github.com/skia-dev/glog/glog.go:640 +0x5a
> > github.com/skia-dev/glog.Fatal(0xc4201a5e48, 0x1, 0x1)
> > 	/usr/local/google/GO/src/github.com/skia-dev/glog/glog.go:1128 +0x53
> >
>
go.skia.org/infra/task_scheduler/go/specs.(*TasksCfgBuilder).MustFinish(0xc4201ed3e0)
> >
>
	/usr/local/google/GO/src/go.skia.org/infra/task_scheduler/go/specs/helpers.go:204
> > +0x9c
> > main.main()
> > 	/usr/local/google/skia/infra/bots/gen_tasks.go:514 +0x157
> > exit status 255
> > 
> > ==============================
> > 
> > ** Presubmit ERRORS **
> > `python infra/bots/infra_tests.py` failed:
> 
> You'll need to run:
> $ go run ./infra/bots/gen_tasks.go
> 
> That regenerates the tasks.json file which needs to be done whenever an asset
> version changes.  That file defines the bots and swarming tasks used in the
new
> buildbotless world.

Alright, that worked. Thanks!

[scroggo_chromium, 2016-10-27 20:56:44]

The CQ bit was checked by scroggo@chromium.org

[scroggo_chromium, 2016-10-27 20:56:44]

The patchset sent to the CQ was uploaded after l-g-t-m from msarett@google.com
Link to the patchset: https://codereview.chromium.org/2452133003/#ps20001
(title: "Run presubmit and update json file")

[commit-bot: I haz the power, 2016-10-27 20:56:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 20:58:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 20:58:19]

Try jobs failed on following builders:
  Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-GN-Trybot on
master.client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU...)

[scroggo, 2016-10-27 21:01:56]

On 2016/10/27 20:58:19, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-GN-Trybot on
> master.client.skia (JOB_FAILED,
>
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU...)

I don't see how that could've been caused by my change... Trying again

[scroggo, 2016-10-27 21:02:01]

The CQ bit was checked by scroggo@google.com

[commit-bot: I haz the power, 2016-10-27 21:02:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 21:23:02]

Description was changed from

==========
Upload an image that demonstrates issue 5883

This GIF is missing a color table. We should draw a blank frame. This
was fixed in crrev.com/2450943002 (DIFFERENT ISSUE). This image will
test this case.

BUG=skia:5883
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2452133003
==========

to

==========
Upload an image that demonstrates issue 5883

This GIF is missing a color table. We should draw a blank frame. This
was fixed in crrev.com/2450943002 (DIFFERENT ISSUE). This image will
test this case.

BUG=skia:5883
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2452133003

Committed:
https://skia.googlesource.com/skia/+/2111633dc63a5b7c629b4cc33f7c67d27e1246e6
==========

[commit-bot: I haz the power, 2016-10-27 21:23:03]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/2111633dc63a5b7c629b4cc33f7c67d27e1246e6